Skip to content

Commit 76d94d3

Browse files
committed
Revert "[ORC] Drop Comdat when discarding IR symbol"
A number of AArch64 bots report errors in clang-repl, for example https://lab.llvm.org/buildbot/#/builders/197/builds/3920 This reverts commit 87d7838.
1 parent a2ae9e3 commit 76d94d3

File tree

3 files changed

+0
-34
lines changed

3 files changed

+0
-34
lines changed

llvm/lib/ExecutionEngine/Orc/Layer.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,6 @@ void IRMaterializationUnit::discard(const JITDylib &JD,
125125
assert(!I->second->isDeclaration() &&
126126
"Discard should only apply to definitions");
127127
I->second->setLinkage(GlobalValue::AvailableExternallyLinkage);
128-
// According to the IR verifier, "Declaration[s] may not be in a Comdat!"
129-
// Remove it, if this is a GlobalObject.
130-
if (auto *GO = dyn_cast<GlobalObject>(I->second))
131-
GO->setComdat(nullptr);
132128
SymbolToDefinition.erase(I);
133129
}
134130

llvm/test/ExecutionEngine/Orc/Inputs/weak-comdat-def.ll

Lines changed: 0 additions & 12 deletions
This file was deleted.

llvm/test/ExecutionEngine/Orc/weak-comdat.ll

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)