Set FP features in Sema methods

Author: spavloff

clang/lib/Parse/ParseCXXInlineMethods.cpp

@@ -603,10 +603,7 @@ void Parser::ParseLexedMethodDef(LexedMethod &LM) {
   // to be re-used for method bodies as well.
   ParseScope FnScope(this, Scope::FnScope | Scope::DeclScope |
                                Scope::CompoundStmtScope);
-
-  // Some function attributes (like OptimizeNoneAttr) affect FP options.
   Sema::FPFeaturesStateRAII SaveFPFeatures(Actions);
-  Actions.applyFunctionAttributesBeforeParsingBody(LM.D);
 
   Actions.ActOnStartOfFunctionDef(getCurScope(), LM.D);
 

clang/lib/Parse/ParseObjc.cpp

@@ -3736,9 +3736,7 @@ void Parser::ParseLexedObjCMethodDefs(LexedMethod &LM, bool parseMethod) {
   ParseScope BodyScope(this, (parseMethod ? Scope::ObjCMethodScope : 0) |
                                  Scope::FnScope | Scope::DeclScope |
                                  Scope::CompoundStmtScope);
-  // Some function attributes (like OptimizeNoneAttr) affect FP options.
   Sema::FPFeaturesStateRAII SaveFPFeatures(Actions);
-  Actions.applyFunctionAttributesBeforeParsingBody(LM.D);
 
   // Tell the actions module that we have entered a method or c-function definition
   // with the specified Declarator for the method/function.

clang/lib/Parse/ParseTemplate.cpp

@@ -1651,10 +1651,6 @@ void Parser::ParseLateTemplatedFuncDef(LateParsedTemplate &LPT) {
   // Recreate the containing function DeclContext.
   Sema::ContextRAII FunctionSavedContext(Actions, FunD->getLexicalParent());
 
-  // Some function attributes (like OptimizeNoneAttr) affect FP options.
-  Sema::FPFeaturesStateRAII SaveFPFeatures(Actions);
-  Actions.applyFunctionAttributesBeforeParsingBody(LPT.D);
-
   Actions.ActOnStartOfFunctionDef(getCurScope(), FunD);
 
   if (Tok.is(tok::kw_try)) {

clang/lib/Parse/Parser.cpp

@@ -1497,9 +1497,7 @@ Decl *Parser::ParseFunctionDefinition(ParsingDeclarator &D,
     return Actions.ActOnFinishFunctionBody(Res, nullptr, false);
   }
 
-  // Some function attributes (like OptimizeNoneAttr) affect FP options.
   Sema::FPFeaturesStateRAII SaveFPFeatures(Actions);
-  Actions.applyFunctionAttributesBeforeParsingBody(Res);
 
   if (Tok.is(tok::kw_try))
     return ParseFunctionTryBlock(Res, BodyScope);

clang/lib/Sema/SemaDecl.cpp

@@ -15899,6 +15899,11 @@ Decl *Sema::ActOnStartOfFunctionDef(Scope *FnBodyScope, Decl *D,
     FD->setInvalidDecl();
     return D;
   }
+
+  // Some function attributes (like OptimizeNoneAttr) need actions before
+  // parsing body started.
+  applyFunctionAttributesBeforeParsingBody(D);
+
   // We want to attach documentation to original Decl (which might be
   // a function template).
   ActOnDocumentableDecl(D);

clang/lib/Sema/SemaDeclObjC.cpp

@@ -494,6 +494,10 @@ void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) {
       }
     }
   }
+
+  // Some function attributes (like OptimizeNoneAttr) need actions before
+  // parsing body started.
+  applyFunctionAttributesBeforeParsingBody(D);
 }
 
 namespace {