Re-arrange getPartialReductionExtendKind

SamTebbs33 · SamTebbs33 · commit 78a89dfed8ec · 2025-06-02T17:13:06.000+01:00
diff --git a/llvm/lib/Analysis/TargetTransformInfo.cpp b/llvm/lib/Analysis/TargetTransformInfo.cpp
@@ -995,10 +995,9 @@ InstructionCost TargetTransformInfo::getShuffleCost(
 
 TargetTransformInfo::PartialReductionExtendKind
 TargetTransformInfo::getPartialReductionExtendKind(Instruction *I) {
-  auto *Cast = dyn_cast<CastInst>(I);
-  if (!Cast)
-    return PR_None;
-  return getPartialReductionExtendKind(Cast->getOpcode());
+  if (auto *Cast = dyn_cast<CastInst>(I))
+    return getPartialReductionExtendKind(Cast->getOpcode());
+  return PR_None;
 }
 
 TargetTransformInfo::PartialReductionExtendKind
@@ -1010,7 +1009,7 @@ TargetTransformInfo::getPartialReductionExtendKind(
   case Instruction::CastOps::SExt:
     return PR_SignExtend;
   default:
-    return PR_None;
+    llvm_unreachable("Unexpected cast opcode");
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -995,10 +995,9 @@ InstructionCost TargetTransformInfo::getShuffleCost(`
`995`	`995`
`996`	`996`	`TargetTransformInfo::PartialReductionExtendKind`
`997`	`997`	`TargetTransformInfo::getPartialReductionExtendKind(Instruction *I) {`
`998`		`- auto *Cast = dyn_cast<CastInst>(I);`
`999`		`- if (!Cast)`
`1000`		`- return PR_None;`
`1001`		`- return getPartialReductionExtendKind(Cast->getOpcode());`
	`998`	`+ if (auto *Cast = dyn_cast<CastInst>(I))`
	`999`	`+ return getPartialReductionExtendKind(Cast->getOpcode());`
	`1000`	`+ return PR_None;`
`1002`	`1001`	`}`
`1003`	`1002`
`1004`	`1003`	`TargetTransformInfo::PartialReductionExtendKind`
`@@ -1010,7 +1009,7 @@ TargetTransformInfo::getPartialReductionExtendKind(`
`1010`	`1009`	`case Instruction::CastOps::SExt:`
`1011`	`1010`	`return PR_SignExtend;`
`1012`	`1011`	`default:`
`1013`		`- return PR_None;`
	`1012`	`+ llvm_unreachable("Unexpected cast opcode");`
`1014`	`1013`	`}`
`1015`	`1014`	`}`
`1016`	`1015`