Skip to content

Commit 78dcd01

Browse files
authored
Improve CI output. (#70236)
There is currently a major problem with the CI output: The information you need to see never appears in the visible log. This is because our logs are very verbose, and list (A) every test as they run it, and (B) every unsupported tests. This can be thousands of lines. (A) was introduced by me when I disabled the PTY progress bar, which doesn't play nice with log files. That change was an improvement, but I have now disabled the PTY on the builders, so we can go back to passing `-s`. When `-s` is passed but no PTY is available, it prints a long friendly progress indicator. (B) is solved here by disabling the printing of unsupported tests at the end of the test suite. While it can be useful on occasion to audit the list of unsupported tests, it's far from a common operation. Instead people want to see the log of their failure. We should upload the xml results, so if auditing is needed, it can be done using that. Hopefully this change will make it so that the test failures appear in the actual log output
1 parent 10508b6 commit 78dcd01

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

libcxx/utils/ci/run-buildbot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ function generate-cmake-base() {
137137
-DLIBUNWIND_ENABLE_WERROR=YES \
138138
-DLIBCXX_ENABLE_CLANG_TIDY=${ENABLE_CLANG_TIDY} \
139139
${ENABLE_STD_MODULES} \
140-
-DLLVM_LIT_ARGS="-v --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
140+
-DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
141141
"${@}"
142142
}
143143

@@ -372,7 +372,7 @@ bootstrapping-build)
372372
-DLLVM_TARGETS_TO_BUILD="host" \
373373
-DRUNTIMES_BUILD_ALLOW_DARWIN=ON \
374374
-DLLVM_ENABLE_ASSERTIONS=ON \
375-
-DLLVM_LIT_ARGS="-v --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
375+
-DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
376376

377377
echo "+++ Running the libc++ and libc++abi tests"
378378
${NINJA} -vC "${BUILD_DIR}" check-runtimes

0 commit comments

Comments
 (0)