Skip to content

Commit 78e50c5

Browse files
committed
[lldb][lldb-dap] clarify the todo.
1 parent 7f7b3f6 commit 78e50c5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lldb/tools/lldb-dap/Handler/ScopesRequestHandler.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,11 @@ static Scope CreateScope(const llvm::StringRef name, int64_t variablesReference,
3636

3737
// TODO: Support "arguments" and "return value" scope.
3838
// At the moment lldb-dap includes the arguments and return_value into the
39-
// "locals" scope. add presentation hint;
39+
// "locals" scope.
4040
// vscode only expands the first non-expensive scope, this causes friction
41-
// as the locals scope will not be expanded. It becomes more annoying when
42-
// the scope has arguments, return_value and locals.
41+
// if we add the arguments above the local scope as the locals scope will not
42+
// be expanded if we enter a function with arguments. It becomes more
43+
// annoying when the scope has arguments, return_value and locals.
4344
if (variablesReference == VARREF_LOCALS)
4445
scope.presentationHint = Scope::eScopePresentationHintLocals;
4546
else if (variablesReference == VARREF_REGS)

0 commit comments

Comments
 (0)