Skip to content

Commit 79a2cf5

Browse files
authored
test-release.sh: Default to letting ninja select the number of build jobs (#73187)
ninja defaults to using ncpus + 2 build jobs, and this extra parallelism helps the script complete faster in my testing on the GitHub runners.
1 parent f42eb15 commit 79a2cf5

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

llvm/utils/release/test-release.sh

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,8 @@ if [ "$Release" != "test" ]; then
246246
fi
247247
fi
248248

249+
UserNumJobs="$NumJobs"
250+
249251
# Figure out how many make processes to run.
250252
if [ -z "$NumJobs" ]; then
251253
NumJobs=`sysctl -n hw.activecpu 2> /dev/null || true`
@@ -260,6 +262,13 @@ if [ -z "$NumJobs" ]; then
260262
NumJobs=3
261263
fi
262264

265+
if [ "$MAKE" = "ninja" ] && [ -z "$UserNumJobs" ]; then
266+
# Rely on default ninja job numbers
267+
J_ARG=""
268+
else
269+
J_ARG="-j $NumJobs"
270+
fi
271+
263272
# Projects list
264273
projects="llvm;clang"
265274
if [ $do_clang_tools = "yes" ]; then
@@ -484,8 +493,8 @@ function build_llvmCore() {
484493

485494
cd $ObjDir
486495
echo "# Compiling llvm $Release-$RC $Flavor"
487-
echo "# ${MAKE} -j $NumJobs $Verbose"
488-
${MAKE} -j $NumJobs $Verbose $BuildTarget \
496+
echo "# ${MAKE} $J_ARG $Verbose"
497+
${MAKE} $J_ARG $Verbose $BuildTarget \
489498
2>&1 | tee $LogDir/llvm.make-Phase$Phase-$Flavor.log > $redir
490499

491500
echo "# Installing llvm $Release-$RC $Flavor"
@@ -508,7 +517,7 @@ function test_llvmCore() {
508517
fi
509518

510519
cd $ObjDir
511-
if ! ( ${MAKE} -j $NumJobs $KeepGoing $Verbose check-all \
520+
if ! ( ${MAKE} $J_ARG $KeepGoing $Verbose check-all \
512521
2>&1 | tee $LogDir/llvm.check-Phase$Phase-$Flavor.log ) ; then
513522
deferred_error $Phase $Flavor "check-all failed"
514523
fi
@@ -519,7 +528,7 @@ function test_llvmCore() {
519528
cmake $TestSuiteSrcDir -G "$generator" -DTEST_SUITE_LIT=$Lit \
520529
-DTEST_SUITE_HOST_CC=$build_compiler
521530

522-
if ! ( ${MAKE} -j $NumJobs $KeepGoing $Verbose check \
531+
if ! ( ${MAKE} $J_ARG $KeepGoing $Verbose check \
523532
2>&1 | tee $LogDir/llvm.check-Phase$Phase-$Flavor.log ) ; then
524533
deferred_error $Phase $Flavor "test suite failed"
525534
fi

0 commit comments

Comments
 (0)