Address code review comments

AmrDeveloper · AmrDeveloper · commit 79c9b9fde6d0 · 2025-06-17T20:46:30.000+02:00
diff --git a/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp b/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
@@ -75,6 +75,8 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,
     mlir::Value complex = builder.createComplexCreate(loc, real, imag);
     return RValue::get(complex);
   }
+    default:
+    break;
   }
 
   cgm.errorNYI(loc, "non constant foldable builtin calls");
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp b/clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp
@@ -74,9 +74,7 @@ mlir::Value ComplexExprEmitter::VisitCallExpr(const CallExpr *e) {
   if (e->getCallReturnType(cgf.getContext())->isReferenceType())
     return emitLoadOfLValue(e);
 
-  mlir::Location loc = cgf.getLoc(e->getExprLoc());
-  auto complex = cgf.emitCallExpr(e).getComplexVal();
-  return builder.createComplexCreate(loc, complex.first, complex.second);
+  return cgf.emitCallExpr(e).getValue();
 }
 
 mlir::Value ComplexExprEmitter::VisitInitListExpr(InitListExpr *e) {

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,8 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,`
`75`	`75`	`mlir::Value complex = builder.createComplexCreate(loc, real, imag);`
`76`	`76`	`return RValue::get(complex);`
`77`	`77`	`}`
	`78`	`+ default:`
	`79`	`+ break;`
`78`	`80`	`}`
`79`	`81`
`80`	`82`	`cgm.errorNYI(loc, "non constant foldable builtin calls");`
Original file line number	Diff line number	Diff line change
`@@ -74,9 +74,7 @@ mlir::Value ComplexExprEmitter::VisitCallExpr(const CallExpr *e) {`
`74`	`74`	`if (e->getCallReturnType(cgf.getContext())->isReferenceType())`
`75`	`75`	`return emitLoadOfLValue(e);`
`76`	`76`
`77`		`- mlir::Location loc = cgf.getLoc(e->getExprLoc());`
`78`		`- auto complex = cgf.emitCallExpr(e).getComplexVal();`
`79`		`- return builder.createComplexCreate(loc, complex.first, complex.second);`
	`77`	`+ return cgf.emitCallExpr(e).getValue();`
`80`	`78`	`}`
`81`	`79`
`82`	`80`	`mlir::Value ComplexExprEmitter::VisitInitListExpr(InitListExpr *e) {`