Skip to content

Commit 7a91ca1

Browse files
committed
[LoopUnroll] Remove repeated debug instructions after blocks have
been merged into the predecessor, It can reduce some compile time in some cases. This change only fixes the situation of loop unrolling, and other situations are not considered. "RemoveRedundantDbgInstrs" seems to be very time-consuming. Thus, we call 'RemoveRedundantDbgInstrs' in 'simplifyLoopAfterUnroll'. fixes: #89073
1 parent 7b040d0 commit 7a91ca1

File tree

2 files changed

+50
-0
lines changed

2 files changed

+50
-0
lines changed

llvm/lib/Transforms/Utils/LoopUnroll.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,10 @@ void llvm::simplifyLoopAfterUnroll(Loop *L, bool SimplifyIVs, LoopInfo *LI,
377377
const DataLayout &DL = L->getHeader()->getModule()->getDataLayout();
378378
SmallVector<WeakTrackingVH, 16> DeadInsts;
379379
for (BasicBlock *BB : L->getBlocks()) {
380+
// Remove repeated debug instructions after loop unrolling.
381+
if (BB->getParent()->getSubprogram())
382+
RemoveRedundantDbgInstrs(BB);
383+
380384
for (Instruction &Inst : llvm::make_early_inc_range(*BB)) {
381385
if (Value *V = simplifyInstruction(&Inst, {DL, nullptr, DT, AC}))
382386
if (LI->replacementPreservesLCSSAForm(&Inst, V))
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt < %s -S -passes=loop-unroll | FileCheck %s
3+
4+
define i64 @d(i1 %tobool.not, i32 %add, i64 %conv23) !dbg !14{
5+
entry:
6+
br label %for.body
7+
8+
for.body: ; preds = %for.body, %entry
9+
; There should be only one "llvm.dbg.vale" after loop unrolling
10+
; CHECK: call void @llvm.dbg.value
11+
; CHECK-NOT: call void @llvm.dbg.value
12+
13+
%k.045 = phi i64 [ 0, %entry ], [ %k.046, %for.body ]
14+
tail call void @llvm.dbg.value(metadata i32 0, metadata !13, metadata !DIExpression()), !dbg !17
15+
%k.046 = add nuw nsw i64 %k.045, 1
16+
%exitcond = icmp ne i64 %k.046, 5
17+
br i1 %exitcond, label %for.body, label %for.end22
18+
19+
for.end22: ; preds = %for.body
20+
ret i64 %k.046
21+
}
22+
23+
; Function Attrs: nocallback nofree nosync nounwind speculatable willreturn memory(none)
24+
declare void @llvm.dbg.value(metadata, metadata, metadata)
25+
26+
!llvm.dbg.cu = !{!0}
27+
!llvm.module.flags = !{!12}
28+
29+
!0 = distinct !DICompileUnit(language: DW_LANG_C89, file: !1, producer: "clang version 19.0.0git (https://github.com/llvm/llvm-project.git ec062f5b33ed22c61742e3c1486f6cba915801e0)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, globals: !2, splitDebugInlining: false, nameTableKind: None)
30+
!1 = !DIFile(filename: "unroll-remove-redundant-dbg.c", directory: "", checksumkind: CSK_MD5, checksum: "aa30a1d8c04deb9b0f3885c258d2b674")
31+
!2 = !{!3, !8, !10}
32+
!3 = !DIGlobalVariableExpression(var: !4, expr: !DIExpression())
33+
!4 = distinct !DIGlobalVariable(name: "a", scope: !0, file: !1, line: 2, type: !5, isLocal: false, isDefinition: true)
34+
!5 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint32_t", file: !6, line: 198, baseType: !7)
35+
!6 = !DIFile(filename: "/usr/include/stdint.h", directory: "", checksumkind: CSK_MD5, checksum: "da031bcff2d0c1d65aa92e7e68a44ef3")
36+
!7 = !DIBasicType(name: "unsigned int", size: 32, encoding: DW_ATE_unsigned)
37+
!8 = !DIGlobalVariableExpression(var: !9, expr: !DIExpression())
38+
!9 = distinct !DIGlobalVariable(name: "c", scope: !0, file: !1, line: 2, type: !5, isLocal: false, isDefinition: true)
39+
!10 = !DIGlobalVariableExpression(var: !11, expr: !DIExpression())
40+
!11 = distinct !DIGlobalVariable(name: "b", scope: !0, file: !1, line: 2, type: !5, isLocal: false, isDefinition: true)
41+
!12 = !{i32 2, !"Debug Info Version", i32 3}
42+
!13 = !DILocalVariable(name: "f", scope: !14, file: !1, line: 4, type: !5)
43+
!14 = distinct !DISubprogram(name: "d", scope: !1, file: !1, line: 3, type: !15, scopeLine: 3, flags: DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !16)
44+
!15 = !DISubroutineType(types: !16)
45+
!16 = !{}
46+
!17 = !DILocation(line: 0, scope: !14)

0 commit comments

Comments
 (0)