Skip to content

Commit 7aa8cae

Browse files
committed
Address feedback nr.2
1 parent 88a816f commit 7aa8cae

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ class DWARFDebugLine {
405405
ParsingState(struct LineTable *LT, uint64_t TableOffset,
406406
function_ref<void(Error)> ErrorHandler);
407407

408-
void resetRowAndSequence(uint64_t Offset = UINT64_MAX);
408+
void resetRowAndSequence(uint64_t Offset);
409409
void appendRowToMatrix();
410410

411411
struct AddrOpIndexDelta {

llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -562,16 +562,12 @@ void DWARFDebugLine::LineTable::clear() {
562562
DWARFDebugLine::ParsingState::ParsingState(
563563
struct LineTable *LT, uint64_t TableOffset,
564564
function_ref<void(Error)> ErrorHandler)
565-
: LineTable(LT), LineTableOffset(TableOffset), ErrorHandler(ErrorHandler) {
566-
resetRowAndSequence();
567-
}
565+
: LineTable(LT), LineTableOffset(TableOffset), ErrorHandler(ErrorHandler) {}
568566

569567
void DWARFDebugLine::ParsingState::resetRowAndSequence(uint64_t Offset) {
570568
Row.reset(LineTable->Prologue.DefaultIsStmt);
571569
Sequence.reset();
572-
if (Offset != UINT64_MAX) {
573-
Sequence.SetSequenceOffset(Offset);
574-
}
570+
Sequence.SetSequenceOffset(Offset);
575571
}
576572

577573
void DWARFDebugLine::ParsingState::appendRowToMatrix() {
@@ -854,7 +850,7 @@ Error DWARFDebugLine::LineTable::parse(
854850
}
855851
// *OffsetPtr points to the end of the prologue - i.e. the start of the first
856852
// sequence. So initialize the first sequence offset accordingly.
857-
State.Sequence.SetSequenceOffset(*OffsetPtr);
853+
State.resetRowAndSequence(*OffsetPtr);
858854

859855
bool TombstonedAddress = false;
860856
auto EmitRow = [&] {

0 commit comments

Comments
 (0)