Address third reound of review comments.

- Fixed some spelling mistakes in comments.
- renamed function that retreives the per global code model.
- updated the AIX specific code in isGVIndirectSymbol.

Author: mandlebug

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

@@ -2691,8 +2691,8 @@ MCSection *TargetLoweringObjectFileXCOFF::getSectionForTOCEntry(
       return XCOFF::XMC_TC;
 
     // Use large code model toc entries for ehinfo symbols as they are
-    // never refrenced directly. The runtime loads their TOC entries
-    // address from the trace-back table.
+    // never refrenced directly. The runtime loads their TOC entry
+    // addresses from the trace-back table.
     if (XSym->isEHInfo())
       return XCOFF::XMC_TE;
 

llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp

@@ -478,7 +478,7 @@ static CodeModel::Model getCodeModel(const PPCSubtarget &S,
                                      const TargetMachine &TM,
                                      const MachineOperand &MO) {
   CodeModel::Model ModuleModel = TM.getCodeModel();
-  // Per global code model is only support on AIX.
+  // Per global code model is only supported on AIX.
   if (!S.isAIXABI())
     return ModuleModel;
 
@@ -502,7 +502,7 @@ static CodeModel::Model getCodeModel(const PPCSubtarget &S,
 }
 
 static std::optional<CodeModel::Model>
-hasPerGlobalCodeModel(const GlobalValue *GV) {
+getPerGlobalCodeModel(const GlobalValue *GV) {
   // Symbols that aren't global variables cannot have the attribute.
   if (!isa<GlobalVariable>(GV))
     return std::nullopt;
@@ -3023,7 +3023,7 @@ bool PPCAIXAsmPrinter::doInitialization(Module &M) {
 
     setCsectAlignment(&G);
     std::optional<CodeModel::Model> OptionalCodeModel =
-        hasPerGlobalCodeModel(&G);
+        getPerGlobalCodeModel(&G);
     if (OptionalCodeModel)
       setOptionalCodeModel(cast<MCSymbolXCOFF>(getSymbol(&G)),
                            *OptionalCodeModel);

llvm/lib/Target/PowerPC/PPCSubtarget.cpp

@@ -208,18 +208,18 @@ void PPCSubtarget::tocDataChecks(unsigned PointerSize,
 }
 
 bool PPCSubtarget::isGVIndirectSymbol(const GlobalValue *GV) const {
+  if (isAIXABI() && isa<GlobalVariable>(GV)) {
+    // On AIX the only symbols that aren't indirect are toc-data.
+    if (cast<GlobalVariable>(GV)->hasAttribute("toc-data"))
+      return false;
+
+    return true;
+  }
+
   // Large code model always uses the TOC even for local symbols.
   if (TM.getCodeModel() == CodeModel::Large)
     return true;
 
-  // AIX may have a per global code model attribute.
-  if (isAIXABI() && isa<GlobalVariable>(GV)) {
-    const GlobalVariable *GVar = cast<GlobalVariable>(GV);
-    std::optional<CodeModel::Model> OptionalCM = GVar->getCodeModel();
-    if (OptionalCM && *OptionalCM == CodeModel::Large)
-      return true;
-  }
-
   if (TM.shouldAssumeDSOLocal(GV))
     return false;
   return true;