Skip to content

Commit 7c16e7d

Browse files
authored
[flang][NFC] Use tablegen to reduce AddAliasTags boilerplate (#92373)
I will make this pass run properly on more top-level operations in a follow up patch.
1 parent e3e0613 commit 7c16e7d

File tree

4 files changed

+2
-7
lines changed

4 files changed

+2
-7
lines changed

flang/include/flang/Optimizer/Transforms/Passes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ namespace fir {
4949
#define GEN_PASS_DECL_ADDDEBUGINFO
5050
#define GEN_PASS_DECL_STACKARRAYS
5151
#define GEN_PASS_DECL_LOOPVERSIONING
52+
#define GEN_PASS_DECL_ADDALIASTAGS
5253
#include "flang/Optimizer/Transforms/Passes.h.inc"
5354

5455
std::unique_ptr<mlir::Pass> createAffineDemotionPass();
@@ -60,7 +61,6 @@ std::unique_ptr<mlir::Pass>
6061
createExternalNameConversionPass(bool appendUnderscore);
6162
std::unique_ptr<mlir::Pass> createMemDataFlowOptPass();
6263
std::unique_ptr<mlir::Pass> createPromoteToAffinePass();
63-
std::unique_ptr<mlir::Pass> createAliasTagsPass();
6464
std::unique_ptr<mlir::Pass>
6565
createAddDebugInfoPass(fir::AddDebugInfoOptions options = {});
6666

flang/include/flang/Optimizer/Transforms/Passes.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,6 @@ def AddAliasTags : Pass<"fir-add-alias-tags", "mlir::ModuleOp"> {
278278
aren't races adding new tags to the mlir context.
279279
}];
280280
let dependentDialects = [ "fir::FIROpsDialect" ];
281-
let constructor = "::fir::createAliasTagsPass()";
282281
}
283282

284283
def SimplifyRegionLite : Pass<"simplify-region-lite", "mlir::ModuleOp"> {

flang/include/flang/Tools/CLOptions.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ inline void createDefaultFIROptimizerPassPipeline(
294294
pm.addPass(fir::createPolymorphicOpConversion());
295295

296296
if (pc.AliasAnalysis && !disableFirAliasTags && !useOldAliasTags)
297-
pm.addPass(fir::createAliasTagsPass());
297+
pm.addPass(fir::createAddAliasTags());
298298

299299
// convert control flow to CFG form
300300
fir::addCfgConversionPass(pm, pc);

flang/lib/Optimizer/Transforms/AddAliasTags.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,3 @@ void AddAliasTagsPass::runOnOperation() {
227227

228228
LLVM_DEBUG(llvm::dbgs() << "=== End " DEBUG_TYPE " ===\n");
229229
}
230-
231-
std::unique_ptr<mlir::Pass> fir::createAliasTagsPass() {
232-
return std::make_unique<AddAliasTagsPass>();
233-
}

0 commit comments

Comments
 (0)