Skip to content

Commit 7c29cef

Browse files
committed
feedback
1 parent d7dfe2b commit 7c29cef

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lld/test/wasm/lto/stub-library.s

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
# RUN: wasm-ld %t.o %t/libfoo.a %p/Inputs/stub.so -o %t.wasm
77
# RUN: obj2yaml %t.wasm | FileCheck %s
88

9-
## The function `bar` is declared in stub.so and depends on `foo`, which happens
10-
## be in an LTO object, in an archive file.
11-
## This verifies that stub library dependencies (required exports) can be defined
12-
## in LTO objects.
9+
## The function `bar` is declared in stub.so and depends on `foo`, which in this
10+
## case is defined in an LTO object, inside an archive file.
11+
## This verifies that stub library dependencies (required exports) can be
12+
## defined in LTO objects.
1313
.functype bar () -> ()
1414

1515
.globl _start

lld/wasm/Driver.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -949,11 +949,11 @@ static void processStubLibrariesPreLTO() {
949949
auto* needed = symtab->find(dep);
950950
if (needed ) {
951951
needed->isUsedInRegularObj = true;
952-
// Like with handleLibcall we have extract any LTO archive members
953-
// that might need to be exported due to stub library symbol being
954-
// used. Without this the LTO object could be extracted during
955-
// processStubLibraries, which is too late since LTO has already
956-
// beeing performed at that point.
952+
// Like with handleLibcall we have to extract any LTO archive
953+
// members that might need to be exported due to stub library
954+
// symbols being referenced. Without this the LTO object could be
955+
// extracted during processStubLibraries, which is too late since
956+
// LTO has already being performed at that point.
957957
if (needed->isLazy() && isa<BitcodeFile>(needed->getFile())) {
958958
if (!config->whyExtract.empty())
959959
ctx.whyExtractRecords.emplace_back(toString(stub_file),

0 commit comments

Comments
 (0)