Skip to content

Commit 7c471e1

Browse files
committed
[lldb][NFC] This test is marked expectedfail for macos version
less-than-14.4. Our CI bot is running macOS 14.1 but I still see FAILs from this text in the CI logs? It may be that the CI is really seeing TestTemplateWithSameArg.py fail and is highlighting this XFAIL test even though it's expected. But I'm not interested enough, I'll try just skipping it altogether on < macOS 14.4. This does mean I'm skipping it on intel where the kernel never had the issue involved.
1 parent 16bbfe1 commit 7c471e1

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@ def get_to_start(self, bkpt_text):
1919
return (target, process, thread, frame, read_watchpoint)
2020

2121
@add_test_categories(["basic_process"])
22-
@expectedFailureAll(
23-
macos_version=["<", "14.4"],
24-
archs=["aarch64", "arm$"],
25-
bugnumber="<rdar://problem/106868647>",
26-
)
22+
# kernel disables wp's over instruction step, fixed in macOS 14.4.
23+
@skipIf(macos_version=["<", "14.4"])
2724
def test_step_over_read_watchpoint(self):
2825
self.build()
2926
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
@@ -62,11 +59,8 @@ def test_step_over_read_watchpoint(self):
6259
self.step_inst_for_watchpoint(1)
6360

6461
@add_test_categories(["basic_process"])
65-
@expectedFailureAll(
66-
macos_version=["<", "14.4"],
67-
archs=["aarch64", "arm$"],
68-
bugnumber="<rdar://problem/106868647>",
69-
)
62+
# kernel disables wp's over instruction step, fixed in macOS 14.4.
63+
@skipIf(macos_version=["<", "14.4"])
7064
def test_step_over_write_watchpoint(self):
7165
self.build()
7266
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(

0 commit comments

Comments
 (0)