Skip to content

Commit 7c4a4f4

Browse files
committed
address Jean's comments about argument handling
in CallInterface
1 parent 27a5100 commit 7c4a4f4

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

flang/lib/Lower/CallInterface.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1002,12 +1002,15 @@ class Fortran::lower::CallInterfaceImpl {
10021002
addPassedArg(PassEntityBy::MutableBox, entity, characteristics);
10031003
} else if (dummyRequiresBox(obj, isBindC)) {
10041004
// Pass as fir.box or fir.class
1005+
if (isValueAttr &&
1006+
!getConverter().getLoweringOptions().getLowerToHighLevelFIR())
1007+
TODO(loc, "assumed shape dummy argument with VALUE attribute");
10051008
Property prop = Property::Box;
10061009
PassEntityBy passBy = PassEntityBy::Box;
1007-
if (isValueAttr) {
1010+
/*if (isValueAttr) {
10081011
passBy = PassEntityBy::BaseAddressValueAttribute;
10091012
prop = Property::Value;
1010-
}
1013+
}*/
10111014
addFirOperand(boxType, nextPassedArgPosition(), prop, attrs);
10121015
addPassedArg(passBy, entity, characteristics);
10131016
} else if (dynamicType.category() ==

0 commit comments

Comments
 (0)