review updates

abhilash1910 · abhilash1910 · commit 7ca6ee78aeb0 · 2025-05-12T18:18:07.000+05:30
diff --git a/llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp b/llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp
@@ -200,9 +200,10 @@ class ExegesisAArch64Target : public ExegesisTarget {
     PM.add(createAArch64ExpandPseudoPass());
   }
 
-  static long prctl_wrapper(int op, long arg2 = 0, long arg3 = 0, long arg4 = 0,
-                            long arg5 = 0) {
-    return prctl(op, arg2, arg3, arg4, arg5);
+  // Converts variadic arguments to `long` and passes zeros for the unused
+  // arg2-arg5, as tested by the Linux kernel.
+  static long prctl_wrapper(int op, long arg2 = 0, long arg3 = 0) {
+    return prctl(op, arg2, arg3, /*arg4=*/0L, /*arg5=*/0L);
   }
 
   const char *getIgnoredOpcodeReasonOrNull(const LLVMState &State,

Original file line number	Diff line number	Diff line change
`@@ -200,9 +200,10 @@ class ExegesisAArch64Target : public ExegesisTarget {`
`200`	`200`	`PM.add(createAArch64ExpandPseudoPass());`
`201`	`201`	`}`
`202`	`202`
`203`		`- static long prctl_wrapper(int op, long arg2 = 0, long arg3 = 0, long arg4 = 0,`
`204`		`- long arg5 = 0) {`
`205`		`- return prctl(op, arg2, arg3, arg4, arg5);`
	`203`	+ // Converts variadic arguments to `long` and passes zeros for the unused
	`204`	`+ // arg2-arg5, as tested by the Linux kernel.`
	`205`	`+ static long prctl_wrapper(int op, long arg2 = 0, long arg3 = 0) {`
	`206`	`+ return prctl(op, arg2, arg3, /arg4=/0L, /arg5=/0L);`
`206`	`207`	`}`
`207`	`208`
`208`	`209`	`const char *getIgnoredOpcodeReasonOrNull(const LLVMState &State,`