Skip to content

Commit 7e61d89

Browse files
committed
[mlir] Apply ClangTidy performance finding
loop variable is copied but only used as const reference
1 parent 927559d commit 7e61d89

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mlir/tools/mlir-rewrite/mlir-rewrite.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ SMRange getOpRange(const OperationDefinition &op) {
3838
const char *startOp = op.scopeLoc.Start.getPointer();
3939
const char *endOp = op.scopeLoc.End.getPointer();
4040

41-
for (auto res : op.resultGroups) {
41+
for (const auto &res : op.resultGroups) {
4242
SMRange range = res.definition.loc;
4343
startOp = std::min(startOp, range.Start.getPointer());
4444
}
@@ -317,7 +317,7 @@ static mlir::RewriterRegistration rewriteSimpleRename("simple-rename",
317317

318318
// Rewriter that insert range markers.
319319
LogicalResult markRanges(RewritePad &rewriteState, raw_ostream &os) {
320-
for (auto it : rewriteState.getOpDefs()) {
320+
for (const auto &it : rewriteState.getOpDefs()) {
321321
auto [startOp, endOp] = getOpRange(it);
322322

323323
rewriteState.insertText(startOp, "<");

0 commit comments

Comments
 (0)