Revert "Add SBValue::GetValueAsAddress API for removing non-addressing metadata"

Revert while I investigate two CI bot failures;
the more important is the lldb-arm-ubuntu where
the FixAddress is removing the 0th bit so we're
adding the `actual=` decorator on a string pointer,

```
Got output:
(char *) strptr = 0x00400817 (actual=0x400816) ptr = [{ },{H}]
```

in TestDataFormatterSmartArray.py line 229.

This reverts commit 4d635be.

Author: jasonmolenda

lldb/bindings/interface/SBValueDocstrings.i

@@ -135,24 +135,6 @@ linked list."
 %feature("docstring", "Expands nested expressions like .a->b[0].c[1]->d."
 ) lldb::SBValue::GetValueForExpressionPath;
 
-%feature("docstring", "     
-      Return the value as an address.  On failure, LLDB_INVALID_ADDRESS
-      will be returned.  On architectures like AArch64, where the
-      top (unaddressable) bits can be used for authentication,
-      memory tagging, or top byte ignore,  this method will return
-      the value with those top bits cleared.
-
-      GetValueAsUnsigned returns the actual value, with the
-      authentication/Top Byte Ignore/Memory Tagging Extension bits.
-
-      Calling this on a random value which is not a pointer is
-      incorrect.  Call GetType().IsPointerType() if in doubt.
-
-      An SB API program may want to show both the literal byte value
-      and the address it refers to in memory.  These two SBValue
-      methods allow SB API writers to behave appropriately for their
-      interface.") lldb::SBValue::GetValueAsAddress;
-
 %feature("doctstring", "
     Returns the number for children.
 

lldb/include/lldb/API/SBValue.h

@@ -62,8 +62,6 @@ class LLDB_API SBValue {
 
   uint64_t GetValueAsUnsigned(uint64_t fail_value = 0);
 
-  lldb::addr_t GetValueAsAddress();
-
   ValueType GetValueType();
 
   // If you call this on a newly created ValueObject, it will always return

lldb/include/lldb/Core/ValueObject.h

@@ -564,10 +564,6 @@ class ValueObject {
 
   lldb::addr_t GetPointerValue(AddressType *address_type = nullptr);
 
-  /// Remove TBI/MTE/ptrauth bits from address, if those are defined on this
-  /// target/ABI.
-  lldb::addr_t GetStrippedPointerValue(lldb::addr_t address);
-
   lldb::ValueObjectSP GetSyntheticChild(ConstString key) const;
 
   lldb::ValueObjectSP GetSyntheticArrayMember(size_t index, bool can_create);

lldb/source/API/SBValue.cpp

@@ -30,7 +30,6 @@
 #include "lldb/Symbol/Type.h"
 #include "lldb/Symbol/Variable.h"
 #include "lldb/Symbol/VariableList.h"
-#include "lldb/Target/ABI.h"
 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Target/Process.h"
 #include "lldb/Target/StackFrame.h"
@@ -925,25 +924,6 @@ uint64_t SBValue::GetValueAsUnsigned(uint64_t fail_value) {
   return fail_value;
 }
 
-lldb::addr_t SBValue::GetValueAsAddress() {
-  addr_t fail_value = LLDB_INVALID_ADDRESS;
-  ValueLocker locker;
-  lldb::ValueObjectSP value_sp(GetSP(locker));
-  if (value_sp) {
-    bool success = true;
-    uint64_t ret_val = fail_value;
-    ret_val = value_sp->GetValueAsUnsigned(fail_value, &success);
-    if (!success)
-      return fail_value;
-    if (ProcessSP process_sp = m_opaque_sp->GetProcessSP())
-      if (ABISP abi_sp = process_sp->GetABI())
-        return abi_sp->FixCodeAddress(ret_val);
-    return ret_val;
-  }
-
-  return fail_value;
-}
-
 bool SBValue::MightHaveChildren() {
   LLDB_INSTRUMENT_VA(this);
 

lldb/source/Core/ValueObject.cpp

@@ -31,7 +31,6 @@
 #include "lldb/Symbol/SymbolContext.h"
 #include "lldb/Symbol/Type.h"
 #include "lldb/Symbol/Variable.h"
-#include "lldb/Target/ABI.h"
 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Target/Language.h"
 #include "lldb/Target/LanguageRuntime.h"
@@ -1454,14 +1453,6 @@ addr_t ValueObject::GetAddressOf(bool scalar_is_load_address,
   return LLDB_INVALID_ADDRESS;
 }
 
-addr_t ValueObject::GetStrippedPointerValue(addr_t address) {
-  ExecutionContext exe_ctx(GetExecutionContextRef());
-  if (Process *process = exe_ctx.GetProcessPtr())
-    if (ABISP abi_sp = process->GetABI())
-      return abi_sp->FixCodeAddress(address);
-  return address;
-}
-
 addr_t ValueObject::GetPointerValue(AddressType *address_type) {
   addr_t address = LLDB_INVALID_ADDRESS;
   if (address_type)
@@ -1477,15 +1468,11 @@ addr_t ValueObject::GetPointerValue(AddressType *address_type) {
     address = m_value.GetScalar().ULongLong(LLDB_INVALID_ADDRESS);
     break;
 
-  case Value::ValueType::HostAddress: {
-    lldb::offset_t data_offset = 0;
-    address = m_data.GetAddress(&data_offset);
-  } break;
-
+  case Value::ValueType::HostAddress:
   case Value::ValueType::LoadAddress:
   case Value::ValueType::FileAddress: {
     lldb::offset_t data_offset = 0;
-    address = GetStrippedPointerValue(m_data.GetAddress(&data_offset));
+    address = m_data.GetAddress(&data_offset);
   } break;
   }
 
@@ -3024,11 +3011,6 @@ lldb::ValueObjectSP ValueObject::CreateValueObjectFromAddress(
   if (type) {
     CompilerType pointer_type(type.GetPointerType());
     if (pointer_type) {
-      if (Process *process = exe_ctx.GetProcessPtr()) {
-        if (ABISP abi_sp = process->GetABI()) {
-          address = abi_sp->FixCodeAddress(address);
-        }
-      }
       lldb::DataBufferSP buffer(
           new lldb_private::DataBufferHeap(&address, sizeof(lldb::addr_t)));
       lldb::ValueObjectSP ptr_result_valobj_sp(ValueObjectConstResult::Create(

lldb/source/DataFormatters/ValueObjectPrinter.cpp

@@ -440,13 +440,6 @@ bool ValueObjectPrinter::PrintValueAndSummaryIfNeeded(bool &value_printed,
           if (!m_options.m_hide_name)
             m_stream->PutChar(' ');
           m_stream->PutCString(m_value);
-          if (IsPointerValue(m_valobj->GetCompilerType())) {
-            uint64_t orig_value = m_valobj->GetValueAsUnsigned(0);
-            addr_t stripped = m_valobj->GetPointerValue();
-            if (stripped != orig_value) {
-              m_stream->Printf(" (actual=0x%" PRIx64 ")", stripped);
-            }
-          }
           value_printed = true;
         }
       }