Skip to content

Commit 7f05153

Browse files
authored
[libc++] Un-xfail module tests in picolibc tests (#78580)
Some of the module tests now pass after picolibc update. #77908 The remaining tests fail and are now set to xfail on picolibc specifically.
1 parent 30da0f5 commit 7f05153

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

libcxx/test/libcxx/selftest/modules/std-and-std.compat-module.sh.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212

1313
// XFAIL: has-no-cxx-module-support
1414

15+
// picolibc does not provide the required timespec_get function, and the
16+
// "using-if-exists" mechanism apparently did not work here.
17+
// XFAIL: LIBCXX-PICOLIBC-FIXME
18+
1519
// Make sure that the compile flags contain the expected elements.
1620
// The tests only look for the expected components and not the exact flags.
1721
// Otherwise changing the location of the module would break this test.

libcxx/test/libcxx/selftest/modules/std.compat-module.sh.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212

1313
// XFAIL: has-no-cxx-module-support
1414

15+
// picolibc does not provide the required timespec_get function, and the
16+
// "using-if-exists" mechanism apparently did not work here.
17+
// XFAIL: LIBCXX-PICOLIBC-FIXME
18+
1519
// Make sure that the compile flags contain the expected elements.
1620
// The tests only look for the expected components and not the exact flags.
1721
// Otherwise changing the location of the module would break this test.

libcxx/test/std/modules/std.compat.pass.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212

1313
// XFAIL: has-no-cxx-module-support
1414

15+
// picolibc does not provide the required timespec_get function, and the
16+
// "using-if-exists" mechanism apparently did not work here.
17+
// XFAIL: LIBCXX-PICOLIBC-FIXME
18+
1519
// A minimal test to validate import works.
1620

1721
// MODULE_DEPENDENCIES: std.compat

libcxx/utils/libcxx/test/features.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,6 @@ def _getAndroidDeviceApi(cfg):
324324
# This is not allowed per C11 7.1.2 Standard headers/6
325325
# Any declaration of a library function shall have external linkage.
326326
when=lambda cfg: "__ANDROID__" in compilerMacros(cfg)
327-
or "__PICOLIBC__" in compilerMacros(cfg)
328327
or platform.system().lower().startswith("aix")
329328
# Avoid building on platforms that don't support modules properly.
330329
or not hasCompileFlag(cfg, "-Wno-reserved-module-identifier"),

0 commit comments

Comments
 (0)