Skip to content

Commit 817f0d9

Browse files
authored
[Flang][OpenMP] NFC: Remove unused argument for omp.target lowering (#97564)
This patch removes the `outerCombined` argument from `genTargetOp()` and the `processReduction` argument from `genTargetClauses()`, as they aren't used.
1 parent 361350f commit 817f0d9

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

flang/lib/Lower/OpenMP/OpenMP.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,7 +1136,7 @@ static void genSingleClauses(lower::AbstractConverter &converter,
11361136
static void genTargetClauses(
11371137
lower::AbstractConverter &converter, semantics::SemanticsContext &semaCtx,
11381138
lower::StatementContext &stmtCtx, const List<Clause> &clauses,
1139-
mlir::Location loc, bool processHostOnlyClauses, bool processReduction,
1139+
mlir::Location loc, bool processHostOnlyClauses,
11401140
mlir::omp::TargetClauseOps &clauseOps,
11411141
llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
11421142
llvm::SmallVectorImpl<mlir::Location> &mapLocs,
@@ -1678,7 +1678,7 @@ static mlir::omp::TargetOp
16781678
genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
16791679
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
16801680
mlir::Location loc, const ConstructQueue &queue,
1681-
ConstructQueue::iterator item, bool outerCombined = false) {
1681+
ConstructQueue::iterator item) {
16821682
fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
16831683
lower::StatementContext stmtCtx;
16841684

@@ -1692,10 +1692,9 @@ genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
16921692
llvm::SmallVector<mlir::Location> mapLocs, devicePtrLocs, deviceAddrLocs;
16931693
llvm::SmallVector<mlir::Type> mapTypes, devicePtrTypes, deviceAddrTypes;
16941694
genTargetClauses(converter, semaCtx, stmtCtx, item->clauses, loc,
1695-
processHostOnlyClauses, /*processReduction=*/outerCombined,
1696-
clauseOps, mapSyms, mapLocs, mapTypes, deviceAddrSyms,
1697-
deviceAddrLocs, deviceAddrTypes, devicePtrSyms,
1698-
devicePtrLocs, devicePtrTypes);
1695+
processHostOnlyClauses, clauseOps, mapSyms, mapLocs,
1696+
mapTypes, deviceAddrSyms, deviceAddrLocs, deviceAddrTypes,
1697+
devicePtrSyms, devicePtrLocs, devicePtrTypes);
16991698

17001699
llvm::SmallVector<const semantics::Symbol *> privateSyms;
17011700
DataSharingProcessor dsp(converter, semaCtx, item->clauses, eval,
@@ -2101,8 +2100,7 @@ static void genOMPDispatch(lower::AbstractConverter &converter,
21012100
genSingleOp(converter, symTable, semaCtx, eval, loc, queue, item);
21022101
break;
21032102
case llvm::omp::Directive::OMPD_target:
2104-
genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item,
2105-
/*outerCombined=*/false);
2103+
genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item);
21062104
break;
21072105
case llvm::omp::Directive::OMPD_target_data:
21082106
genTargetDataOp(converter, symTable, semaCtx, eval, loc, queue, item);

0 commit comments

Comments
 (0)