Skip to content

Commit 8260528

Browse files
fhahnfhahn
committed
[LAA] Also clear CheckingGroups in RuntimePointerChecking::reset.
This fixes a crash when trying to print access-info in the newly added test cases.
1 parent e75e617 commit 8260528

File tree

2 files changed

+246
-0
lines changed

2 files changed

+246
-0
lines changed

‎llvm/include/llvm/Analysis/LoopAccessAnalysis.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,7 @@ class RuntimePointerChecking {
497497
Pointers.clear();
498498
Checks.clear();
499499
DiffChecks.clear();
500+
CheckingGroups.clear();
500501
}
501502

502503
/// Insert a pointer and calculate the start and end SCEVs.

‎llvm/test/Analysis/LoopAccessAnalysis/retry-runtime-checks-after-dependence-analysis.ll

Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt -passes='print<access-info>' -disable-output %s 2>&1 | FileCheck %s
3+
4+
define void @dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step5(ptr %a, ptr %b, i64 %offset, i64 %n) {
5+
; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step5'
6+
; CHECK-NEXT: loop:
7+
; CHECK-NEXT: Memory dependences are safe with run-time checks
8+
; CHECK-NEXT: Dependences:
9+
; CHECK-NEXT: Run-time memory checks:
10+
; CHECK-NEXT: Check 0:
11+
; CHECK-NEXT: Comparing group ([[GRP1:0x[0-9a-f]+]]):
12+
; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
13+
; CHECK-NEXT: Against group ([[GRP2:0x[0-9a-f]+]]):
14+
; CHECK-NEXT: %gep.b = getelementptr inbounds float, ptr %b, i64 %iv2
15+
; CHECK-NEXT: Check 1:
16+
; CHECK-NEXT: Comparing group ([[GRP1]]):
17+
; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
18+
; CHECK-NEXT: Against group ([[GRP3:0x[0-9a-f]+]]):
19+
; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
20+
; CHECK-NEXT: Check 2:
21+
; CHECK-NEXT: Comparing group ([[GRP2]]):
22+
; CHECK-NEXT: %gep.b = getelementptr inbounds float, ptr %b, i64 %iv2
23+
; CHECK-NEXT: Against group ([[GRP3]]):
24+
; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
25+
; CHECK-NEXT: Grouped accesses:
26+
; CHECK-NEXT: Group [[GRP1]]:
27+
; CHECK-NEXT: (Low: %a High: ((4 * %n) + %a))
28+
; CHECK-NEXT: Member: {%a,+,4}<nuw><%loop>
29+
; CHECK-NEXT: Group [[GRP2]]:
30+
; CHECK-NEXT: (Low: %b High: (-16 + (20 * %n) + %b))
31+
; CHECK-NEXT: Member: {%b,+,20}<%loop>
32+
; CHECK-NEXT: Group [[GRP3]]:
33+
; CHECK-NEXT: (Low: ((4 * %offset) + %a) High: ((4 * %offset) + (4 * %n) + %a))
34+
; CHECK-NEXT: Member: {((4 * %offset) + %a),+,4}<%loop>
35+
; CHECK-EMPTY:
36+
; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
37+
; CHECK-NEXT: SCEV assumptions:
38+
; CHECK-EMPTY:
39+
; CHECK-NEXT: Expressions re-written:
40+
;
41+
entry:
42+
br label %loop
43+
44+
loop:
45+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
46+
%iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
47+
%gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
48+
%l1 = load float, ptr %gep.a.iv, align 4
49+
%iv.offset = add i64 %iv, %offset
50+
%gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
51+
%l2 = load float, ptr %gep.a.iv.off, align 4
52+
%ad = fadd fast float %l1, %l2
53+
store float %ad, ptr %gep.a.iv, align 4
54+
%gep.b = getelementptr inbounds float, ptr %b, i64 %iv2
55+
store float 0.0, ptr %gep.b
56+
%iv.next = add nuw nsw i64 %iv, 1
57+
%iv2.next = add i64 %iv2, 5
58+
%exitcond = icmp eq i64 %iv.next, %n
59+
br i1 %exitcond, label %exit, label %loop
60+
61+
exit:
62+
ret void
63+
}
64+
65+
define void @dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step5(ptr %a, ptr %b, i64 %offset, i64 %n) {
66+
; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step5'
67+
; CHECK-NEXT: loop:
68+
; CHECK-NEXT: Report: cannot check memory dependencies at runtime
69+
; CHECK-NEXT: Dependences:
70+
; CHECK-NEXT: Run-time memory checks:
71+
; CHECK-NEXT: Grouped accesses:
72+
; CHECK-EMPTY:
73+
; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
74+
; CHECK-NEXT: SCEV assumptions:
75+
; CHECK-EMPTY:
76+
; CHECK-NEXT: Expressions re-written:
77+
;
78+
entry:
79+
br label %loop
80+
81+
loop:
82+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
83+
%iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
84+
%gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
85+
%l1 = load float, ptr %gep.a.iv, align 4
86+
%iv.offset = add i64 %iv, %offset
87+
%gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
88+
%l2 = load float, ptr %gep.a.iv.off, align 4
89+
%ad = fadd fast float %l1, %l2
90+
store float %ad, ptr %gep.a.iv, align 4
91+
%gep.b = getelementptr i8, ptr %b, i64 %iv2
92+
store float 0.0, ptr %gep.b
93+
%iv.next = add nuw nsw i64 %iv, 1
94+
%iv2.next = add i64 %iv2, 5
95+
%exitcond = icmp eq i64 %iv.next, %n
96+
br i1 %exitcond, label %exit, label %loop
97+
98+
exit:
99+
ret void
100+
}
101+
102+
define void @dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step_not_constant(ptr %a, ptr %b, i64 %offset, i64 %n, i64 %s) {
103+
; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step_not_constant'
104+
; CHECK-NEXT: loop:
105+
; CHECK-NEXT: Report: cannot check memory dependencies at runtime
106+
; CHECK-NEXT: Dependences:
107+
; CHECK-NEXT: Run-time memory checks:
108+
; CHECK-NEXT: Grouped accesses:
109+
; CHECK-EMPTY:
110+
; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
111+
; CHECK-NEXT: SCEV assumptions:
112+
; CHECK-NEXT: Equal predicate: %s == 1
113+
; CHECK-EMPTY:
114+
; CHECK-NEXT: Expressions re-written:
115+
; CHECK-NEXT: [PSE] %gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2:
116+
; CHECK-NEXT: {%b,+,%s}<%loop>
117+
; CHECK-NEXT: --> {%b,+,1}<%loop>
118+
;
119+
entry:
120+
br label %loop
121+
122+
loop:
123+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
124+
%iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
125+
%gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
126+
%l1 = load float, ptr %gep.a.iv, align 4
127+
%iv.offset = add i64 %iv, %offset
128+
%gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
129+
%l2 = load float, ptr %gep.a.iv.off, align 4
130+
%ad = fadd fast float %l1, %l2
131+
store float %ad, ptr %gep.a.iv, align 4
132+
%gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2
133+
store float 0.0, ptr %gep.b
134+
%iv.next = add nuw nsw i64 %iv, 1
135+
%iv2.next = add i64 %iv2, %s
136+
%exitcond = icmp eq i64 %iv.next, %n
137+
br i1 %exitcond, label %exit, label %loop
138+
139+
exit:
140+
ret void
141+
}
142+
143+
144+
define void @dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step_not_constant(ptr %a, ptr %b, i64 %offset, i64 %n, i64 %s) {
145+
; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step_not_constant'
146+
; CHECK-NEXT: loop:
147+
; CHECK-NEXT: Report: cannot check memory dependencies at runtime
148+
; CHECK-NEXT: Dependences:
149+
; CHECK-NEXT: Run-time memory checks:
150+
; CHECK-NEXT: Grouped accesses:
151+
; CHECK-EMPTY:
152+
; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
153+
; CHECK-NEXT: SCEV assumptions:
154+
; CHECK-NEXT: Equal predicate: %s == 1
155+
; CHECK-EMPTY:
156+
; CHECK-NEXT: Expressions re-written:
157+
; CHECK-NEXT: [PSE] %gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2:
158+
; CHECK-NEXT: {%b,+,%s}<%loop>
159+
; CHECK-NEXT: --> {%b,+,1}<%loop>
160+
;
161+
entry:
162+
br label %loop
163+
164+
loop:
165+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
166+
%iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
167+
%gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
168+
%l1 = load float, ptr %gep.a.iv, align 4
169+
%iv.offset = add i64 %iv, %offset
170+
%gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
171+
%l2 = load float, ptr %gep.a.iv.off, align 4
172+
%ad = fadd fast float %l1, %l2
173+
store float %ad, ptr %gep.a.iv, align 4
174+
%gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2
175+
store float 0.0, ptr %gep.b
176+
%iv.next = add nuw nsw i64 %iv, 1
177+
%iv2.next = add i64 %iv2, %s
178+
%exitcond = icmp eq i64 %iv.next, %n
179+
br i1 %exitcond, label %exit, label %loop
180+
181+
exit:
182+
ret void
183+
}
184+
185+
define void @dependency_check_and_runtime_checks_needed_gepb_may_wrap(ptr %a, ptr %b, i64 %offset, i64 %n) {
186+
; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_may_wrap'
187+
; CHECK-NEXT: loop:
188+
; CHECK-NEXT: Memory dependences are safe with run-time checks
189+
; CHECK-NEXT: Dependences:
190+
; CHECK-NEXT: Run-time memory checks:
191+
; CHECK-NEXT: Check 0:
192+
; CHECK-NEXT: Comparing group ([[GRP4:0x[0-9a-f]+]]):
193+
; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
194+
; CHECK-NEXT: Against group ([[GRP5:0x[0-9a-f]+]]):
195+
; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
196+
; CHECK-NEXT: Check 1:
197+
; CHECK-NEXT: Comparing group ([[GRP4]]):
198+
; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
199+
; CHECK-NEXT: Against group ([[GRP6:0x[0-9a-f]+]]):
200+
; CHECK-NEXT: %gep.b = getelementptr float, ptr %b, i64 %iv2
201+
; CHECK-NEXT: Check 2:
202+
; CHECK-NEXT: Comparing group ([[GRP5]]):
203+
; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
204+
; CHECK-NEXT: Against group ([[GRP6]]):
205+
; CHECK-NEXT: %gep.b = getelementptr float, ptr %b, i64 %iv2
206+
; CHECK-NEXT: Grouped accesses:
207+
; CHECK-NEXT: Group [[GRP4]]:
208+
; CHECK-NEXT: (Low: %a High: ((4 * %n) + %a))
209+
; CHECK-NEXT: Member: {%a,+,4}<nuw><%loop>
210+
; CHECK-NEXT: Group [[GRP5]]:
211+
; CHECK-NEXT: (Low: ((4 * %offset) + %a) High: ((4 * %offset) + (4 * %n) + %a))
212+
; CHECK-NEXT: Member: {((4 * %offset) + %a),+,4}<%loop>
213+
; CHECK-NEXT: Group [[GRP6]]:
214+
; CHECK-NEXT: (Low: %b High: (-4 + (8 * %n) + %b))
215+
; CHECK-NEXT: Member: {%b,+,8}<%loop>
216+
; CHECK-EMPTY:
217+
; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
218+
; CHECK-NEXT: SCEV assumptions:
219+
; CHECK-NEXT: {%b,+,8}<%loop> Added Flags: <nusw>
220+
; CHECK-EMPTY:
221+
; CHECK-NEXT: Expressions re-written:
222+
;
223+
entry:
224+
br label %loop
225+
226+
loop:
227+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
228+
%iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
229+
%gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
230+
%l1 = load float, ptr %gep.a.iv, align 4
231+
%iv.offset = add i64 %iv, %offset
232+
%gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
233+
%l2 = load float, ptr %gep.a.iv.off, align 4
234+
%ad = fadd fast float %l1, %l2
235+
store float %ad, ptr %gep.a.iv, align 4
236+
%gep.b = getelementptr float, ptr %b, i64 %iv2
237+
store float 0.0, ptr %gep.b
238+
%iv.next = add nuw nsw i64 %iv, 1
239+
%iv2.next = add i64 %iv2, 2
240+
%exitcond = icmp eq i64 %iv.next, %n
241+
br i1 %exitcond, label %exit, label %loop
242+
243+
exit:
244+
ret void
245+
}

0 commit comments

Comments
 (0)