fixup! rename property

Author: felipepiovezan

lldb/include/lldb/Target/Language.h

@@ -339,12 +339,12 @@ class Language : public PluginInterface {
 
   virtual llvm::StringRef GetInstanceVariableName() { return {}; }
 
-  // Returns true if this SymbolContext should be used when setting breakpoints
-  // by line (number or regex). This is useful for languages that create
-  // artificial functions without any meaningful user code associated with them
-  // (e.g. code that gets expanded in late compilation stages, like by
-  // CoroSplitter).
-  virtual bool IsArtificialCtxForLineBreakpoint(const SymbolContext &) const {
+  /// Returns true if this SymbolContext should be ignored when setting
+  /// breakpoints by line (number or regex). This is useful for languages that
+  /// create artificial functions without any meaningful user code associated
+  /// with them (e.g. code that gets expanded in late compilation stages, like
+  /// by CoroSplitter).
+  virtual bool IgnoreForLineBreakpoints(const SymbolContext &) const {
     return false;
   }
 

lldb/include/lldb/Target/Target.h

@@ -258,7 +258,7 @@ class TargetProperties : public Properties {
 
   bool GetDebugUtilityExpression() const;
 
-  bool GetIgnoreBreakpointsFromLanguageArtificialLocations() const;
+  bool GetEnableLanguageFilterForLineBreakpoints() const;
 
 private:
   // Callbacks for m_launch_info.

lldb/source/Breakpoint/BreakpointResolver.cpp

@@ -205,14 +205,12 @@ void BreakpointResolver::SetSCMatchesByLine(
     llvm::StringRef log_ident, uint32_t line, std::optional<uint16_t> column) {
   llvm::SmallVector<SymbolContext, 16> all_scs;
   const bool ShouldQueryLanguageFilter =
-      GetBreakpoint()
-          ->GetTarget()
-          .GetIgnoreBreakpointsFromLanguageArtificialLocations();
+      GetBreakpoint()->GetTarget().GetEnableLanguageFilterForLineBreakpoints();
 
   for (uint32_t i = 0; i < sc_list.GetSize(); ++i) {
     if (ShouldQueryLanguageFilter)
       if (Language *lang = Language::FindPlugin(sc_list[i].GetLanguage());
-          lang && lang->IsArtificialCtxForLineBreakpoint(sc_list[i]))
+          lang && lang->IgnoreForLineBreakpoints(sc_list[i]))
         continue;
     all_scs.push_back(sc_list[i]);
   }

lldb/source/Target/Target.cpp

@@ -4896,10 +4896,8 @@ void TargetProperties::SetDebugUtilityExpression(bool debug) {
   SetPropertyAtIndex(idx, debug);
 }
 
-bool TargetProperties::GetIgnoreBreakpointsFromLanguageArtificialLocations()
-    const {
-  const uint32_t idx =
-      ePropertyIgnoreBreakpointsFromLanguageArtificialLocations;
+bool TargetProperties::GetEnableLanguageFilterForLineBreakpoints() const {
+  const uint32_t idx = ePropertyEnableLanguageFilterForLineBreakpoints;
   return GetPropertyAtIndexAs<bool>(
       idx, g_target_properties[idx].default_uint_value != 0);
 }

lldb/source/Target/TargetProperties.td

@@ -104,9 +104,9 @@ let Definition = "target" in {
   def BreakpointUseAvoidList: Property<"breakpoints-use-platform-avoid-list", "Boolean">,
     DefaultTrue,
     Desc<"Consult the platform module avoid list when setting non-module specific breakpoints.">;
-  def IgnoreBreakpointsFromLanguageArtificialLocations: Property<"ignore-breakpoints-from-language-artificial-locations", "Boolean">,
+  def EnableLanguageFilterForLineBreakpoints: Property<"enable-language-filter-for-line-breakpoints", "Boolean">,
     DefaultTrue,
-    Desc<"If true, locations that are considered artificial by the source Language plugin will be ignored when setting breakpoints by line number or regex.">;
+    Desc<"If true, allow Language plugins to filter locations when setting breakpoints by line number or regex.">;
   def Arg0: Property<"arg0", "String">,
     DefaultStringValue<"">,
     Desc<"The first argument passed to the program in the argument array which can be different from the executable itself.">;