Skip to content

Commit 83b1785

Browse files
committed
[flang] Fix build issue in flang caused by adding new LLVM IR instructions in #137701
Fix a compile error (with LLVM_ENABLE_WERROR=On) when building `bin/flang`: ``` enumeration values 'FMaximum' and 'FMinimum' not handled in switch ``` caused by adding new LLVM IR instructions in #137701. This wasn't picked up by the auto CI test on GitHub, so I hadn't realised until @kazutakahirata notified me about it.
1 parent 334e05b commit 83b1785

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

mlir/include/mlir/Dialect/LLVMIR/LLVMEnums.td

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ def AtomicBinOpUSubCond : LLVM_EnumAttrCase<"usub_cond",
110110
"usub_cond", "USubCond", 17>;
111111
def AtomicBinOpUSubSat : LLVM_EnumAttrCase<"usub_sat",
112112
"usub_sat", "USubSat", 18>;
113+
def AtomicBinOpFMaximum : LLVM_EnumAttrCase<"fmaximum", "fmaximum", "FMaximum", 19>;
114+
def AtomicBinOpFMinimum : LLVM_EnumAttrCase<"fminimum", "fminimum", "FMinimum", 20>;
113115

114116
// A sentinel value that has no MLIR counterpart.
115117
def AtomicBadBinOp : LLVM_EnumAttrCase<"", "", "BAD_BINOP", 0>;
@@ -122,7 +124,8 @@ def AtomicBinOp : LLVM_EnumAttr<
122124
AtomicBinOpNand, AtomicBinOpOr, AtomicBinOpXor, AtomicBinOpMax,
123125
AtomicBinOpMin, AtomicBinOpUMax, AtomicBinOpUMin, AtomicBinOpFAdd,
124126
AtomicBinOpFSub, AtomicBinOpFMax, AtomicBinOpFMin, AtomicBinOpUIncWrap,
125-
AtomicBinOpUDecWrap, AtomicBinOpUSubCond, AtomicBinOpUSubSat],
127+
AtomicBinOpUDecWrap, AtomicBinOpUSubCond, AtomicBinOpUSubSat,
128+
AtomicBinOpFMaximum, AtomicBinOpFMinimum],
126129
[AtomicBadBinOp]> {
127130
let cppNamespace = "::mlir::LLVM";
128131
}

0 commit comments

Comments
 (0)