Skip to content

Commit 83d53c3

Browse files
committed
[Flang][OpenMP] NFC: Remove unused argument for omp.target lowering
This patch removes the `outerCombined` argument from `genTargetOp()` and the `processReduction` argument from `genTargetClauses()`, as they aren't used.
1 parent 5cce160 commit 83d53c3

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

flang/lib/Lower/OpenMP/OpenMP.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1134,7 +1134,7 @@ static void genSingleClauses(lower::AbstractConverter &converter,
11341134
static void genTargetClauses(
11351135
lower::AbstractConverter &converter, semantics::SemanticsContext &semaCtx,
11361136
lower::StatementContext &stmtCtx, const List<Clause> &clauses,
1137-
mlir::Location loc, bool processHostOnlyClauses, bool processReduction,
1137+
mlir::Location loc, bool processHostOnlyClauses,
11381138
mlir::omp::TargetClauseOps &clauseOps,
11391139
llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
11401140
llvm::SmallVectorImpl<mlir::Location> &mapLocs,
@@ -1676,7 +1676,7 @@ static mlir::omp::TargetOp
16761676
genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
16771677
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
16781678
mlir::Location loc, const ConstructQueue &queue,
1679-
ConstructQueue::iterator item, bool outerCombined = false) {
1679+
ConstructQueue::iterator item) {
16801680
fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
16811681
lower::StatementContext stmtCtx;
16821682

@@ -1690,10 +1690,9 @@ genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
16901690
llvm::SmallVector<mlir::Location> mapLocs, devicePtrLocs, deviceAddrLocs;
16911691
llvm::SmallVector<mlir::Type> mapTypes, devicePtrTypes, deviceAddrTypes;
16921692
genTargetClauses(converter, semaCtx, stmtCtx, item->clauses, loc,
1693-
processHostOnlyClauses, /*processReduction=*/outerCombined,
1694-
clauseOps, mapSyms, mapLocs, mapTypes, deviceAddrSyms,
1695-
deviceAddrLocs, deviceAddrTypes, devicePtrSyms,
1696-
devicePtrLocs, devicePtrTypes);
1693+
processHostOnlyClauses, clauseOps, mapSyms, mapLocs,
1694+
mapTypes, deviceAddrSyms, deviceAddrLocs, deviceAddrTypes,
1695+
devicePtrSyms, devicePtrLocs, devicePtrTypes);
16971696

16981697
llvm::SmallVector<const semantics::Symbol *> privateSyms;
16991698
DataSharingProcessor dsp(converter, semaCtx, item->clauses, eval,
@@ -2099,8 +2098,7 @@ static void genOMPDispatch(lower::AbstractConverter &converter,
20992098
genSingleOp(converter, symTable, semaCtx, eval, loc, queue, item);
21002099
break;
21012100
case llvm::omp::Directive::OMPD_target:
2102-
genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item,
2103-
/*outerCombined=*/false);
2101+
genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item);
21042102
break;
21052103
case llvm::omp::Directive::OMPD_target_data:
21062104
genTargetDataOp(converter, symTable, semaCtx, eval, loc, queue, item);

0 commit comments

Comments
 (0)