Skip to content

Commit 858a286

Browse files
committed
[lldb] Remove outdated comment and radar link (NFC)
The comment and radar referenced PyThreadState_Get which is no longer used there and instead has been replaced to a call to PyThreadState_GetDict which has different semantics. Unlike PyThreadState_Get, it can return NULL and it is okay to call this function when no current thread state is available.
1 parent 893d53d commit 858a286

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -582,10 +582,6 @@ void ScriptInterpreterPythonImpl::LeaveSession() {
582582
// up believing we have no thread state and PyImport_AddModule will crash if
583583
// that is the case - since that seems to only happen when destroying the
584584
// SBDebugger, we can make do without clearing up stdout and stderr
585-
586-
// rdar://problem/11292882
587-
// When the current thread state is NULL, PyThreadState_Get() issues a fatal
588-
// error.
589585
if (PyThreadState_GetDict()) {
590586
PythonDictionary &sys_module_dict = GetSysModuleDictionary();
591587
if (sys_module_dict.IsValid()) {
@@ -1783,7 +1779,7 @@ lldb::StateType ScriptInterpreterPythonImpl::ScriptedThreadPlanGetRunState(
17831779

17841780
bool
17851781
ScriptInterpreterPythonImpl::ScriptedThreadPlanGetStopDescription(
1786-
StructuredData::ObjectSP implementor_sp, lldb_private::Stream *stream,
1782+
StructuredData::ObjectSP implementor_sp, lldb_private::Stream *stream,
17871783
bool &script_error) {
17881784
StructuredData::Generic *generic = nullptr;
17891785
if (implementor_sp)

0 commit comments

Comments
 (0)