Skip to content

Commit 86e1283

Browse files
committed
[NFC] update coding standard links to HTTPS
Update one link which redirected, and remove an Amazon ref. llvm-svn: 332735
1 parent 7112fe6 commit 86e1283

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

llvm/docs/CodingStandards.rst

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ guidance below to help you know what to expect.
9191

9292
Each toolchain provides a good reference for what it accepts:
9393

94-
* Clang: http://clang.llvm.org/cxx_status.html
95-
* GCC: http://gcc.gnu.org/projects/cxx0x.html
96-
* MSVC: http://msdn.microsoft.com/en-us/library/hh567368.aspx
94+
* Clang: https://clang.llvm.org/cxx_status.html
95+
* GCC: https://gcc.gnu.org/projects/cxx-status.html#cxx11
96+
* MSVC: https://msdn.microsoft.com/en-us/library/hh567368.aspx
9797

9898
In most cases, the MSVC list will be the dominating factor. Here is a summary
9999
of the features that are expected to work. Features not on this list are
@@ -184,7 +184,7 @@ you hit a type trait which doesn't work we can then add support to LLVM's
184184
traits header to emulate it.
185185

186186
.. _the libstdc++ manual:
187-
http://gcc.gnu.org/onlinedocs/gcc-4.8.0/libstdc++/manual/manual/status.html#status.iso.2011
187+
https://gcc.gnu.org/onlinedocs/gcc-4.8.0/libstdc++/manual/manual/status.html#status.iso.2011
188188

189189
Other Languages
190190
---------------
@@ -591,7 +591,7 @@ understood for formatting nested function calls. Examples:
591591
This formatting scheme also makes it particularly easy to get predictable,
592592
consistent, and automatic formatting with tools like `Clang Format`_.
593593

594-
.. _Clang Format: http://clang.llvm.org/docs/ClangFormat.html
594+
.. _Clang Format: https://clang.llvm.org/docs/ClangFormat.html
595595

596596
Language and Compiler Issues
597597
----------------------------
@@ -667,14 +667,14 @@ Do not use Static Constructors
667667
Static constructors and destructors (e.g. global variables whose types have a
668668
constructor or destructor) should not be added to the code base, and should be
669669
removed wherever possible. Besides `well known problems
670-
<http://yosefk.com/c++fqa/ctors.html#fqa-10.12>`_ where the order of
670+
<https://yosefk.com/c++fqa/ctors.html#fqa-10.12>`_ where the order of
671671
initialization is undefined between globals in different source files, the
672672
entire concept of static constructors is at odds with the common use case of
673673
LLVM as a library linked into a larger application.
674674

675675
Consider the use of LLVM as a JIT linked into another application (perhaps for
676-
`OpenGL, custom languages <http://llvm.org/Users.html>`_, `shaders in movies
677-
<http://llvm.org/devmtg/2010-11/Gritz-OpenShadingLang.pdf>`_, etc). Due to the
676+
`OpenGL, custom languages <https://llvm.org/Users.html>`_, `shaders in movies
677+
<https://llvm.org/devmtg/2010-11/Gritz-OpenShadingLang.pdf>`_, etc). Due to the
678678
design of static constructors, they must be executed at startup time of the
679679
entire application, regardless of whether or how LLVM is used in that larger
680680
application. There are two problems with this:
@@ -692,7 +692,7 @@ target or other library into an application, but static constructors violate
692692
this goal.
693693

694694
That said, LLVM unfortunately does contain static constructors. It would be a
695-
`great project <http://llvm.org/PR11944>`_ for someone to purge all static
695+
`great project <https://llvm.org/PR11944>`_ for someone to purge all static
696696
constructors from LLVM, and then enable the ``-Wglobal-constructors`` warning
697697
flag (when building with Clang) to ensure we do not regress in the future.
698698

@@ -1697,12 +1697,12 @@ A lot of these comments and recommendations have been culled from other sources.
16971697
Two particularly important books for our work are:
16981698

16991699
#. `Effective C++
1700-
<http://www.amazon.com/Effective-Specific-Addison-Wesley-Professional-Computing/dp/0321334876>`_
1700+
<https://www.amazon.com/Effective-Specific-Addison-Wesley-Professional-Computing/dp/0321334876>`_
17011701
by Scott Meyers. Also interesting and useful are "More Effective C++" and
17021702
"Effective STL" by the same author.
17031703

17041704
#. `Large-Scale C++ Software Design
1705-
<http://www.amazon.com/Large-Scale-Software-Design-John-Lakos/dp/0201633620/ref=sr_1_1>`_
1705+
<https://www.amazon.com/Large-Scale-Software-Design-John-Lakos/dp/0201633620>`_
17061706
by John Lakos
17071707

17081708
If you get some free time, and you haven't read them: do so, you might learn

0 commit comments

Comments
 (0)