[analyzer] Partial revert of #127017 (#128642)

steakhal · web-flow · commit 87dc245f3e65 · 2025-02-25T10:37:40.000+01:00
This assertion was hit, as reported by a user. #128427 (comment) Ideally, we would reduce and add a regression test for this, but I don't have the bandwidth for it. See the summary of the issue #128427 for the reproducer.
diff --git a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
@@ -314,7 +314,6 @@ void MacOSKeychainAPIChecker::checkPreStmt(const CallExpr *CE,
     RegionArgIsBad = true;
   }
 
-  assert(ArgSM);
   // Is the argument to the call being tracked?
   const AllocationState *AS = State->get<AllocatedData>(ArgSM);
   if (!AS)

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,6 @@ void MacOSKeychainAPIChecker::checkPreStmt(const CallExpr *CE,`
`314`	`314`	`RegionArgIsBad = true;`
`315`	`315`	`}`
`316`	`316`
`317`		`- assert(ArgSM);`
`318`	`317`	`// Is the argument to the call being tracked?`
`319`	`318`	`const AllocationState *AS = State->get<AllocatedData>(ArgSM);`
`320`	`319`	`if (!AS)`