Formatting and documentation

Author: angelz913

mlir/include/mlir/Dialect/SPIRV/Transforms/SPIRVConversion.h

@@ -189,6 +189,8 @@ Value getVulkanElementPtr(const SPIRVTypeConverter &typeConverter,
                           MemRefType baseType, Value basePtr,
                           ValueRange indices, Location loc, OpBuilder &builder);
 
+// Find the largest factor of size among {2,3,4} for the lowest dimension of
+// the target shape.
 int getComputeVectorSize(int64_t size);
 
 // GetNativeVectorShape implementation for reduction ops.

mlir/lib/Conversion/ConvertToSPIRV/ConvertToSPIRVPass.cpp

@@ -59,7 +59,6 @@ struct ConvertToSPIRVPass final
     }
 
     if (runVectorUnrolling) {
-
       // Fold transpose ops if possible as we cannot unroll it later.
       {
         RewritePatternSet patterns(context);

mlir/test/Conversion/ConvertToSPIRV/vector-unroll.mlir

@@ -99,4 +99,4 @@ func.func @transpose(%arg0 : vector<2x3xi32>) -> (vector<3x2xi32>) {
   // CHECK: return %[[INSERT1]], %[[INSERT3]], %[[INSERT5]] : vector<2xi32>, vector<2xi32>, vector<2xi32>
   %0 = vector.transpose %arg0, [1, 0] : vector<2x3xi32> to vector<3x2xi32>
   return %0 : vector<3x2xi32>
-}
+}