Skip to content

Commit 89c556c

Browse files
authored
[flang][OpenMP] Follow-up to build-breakage fix (#102028)
Adjust the handling of a few of the new clauses.
1 parent 8b4d4be commit 89c556c

File tree

2 files changed

+7
-25
lines changed

2 files changed

+7
-25
lines changed

flang/lib/Lower/OpenMP/Clauses.cpp

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -218,9 +218,9 @@ MAKE_EMPTY_CLASS(Full, Full);
218218
MAKE_EMPTY_CLASS(Inbranch, Inbranch);
219219
MAKE_EMPTY_CLASS(Mergeable, Mergeable);
220220
MAKE_EMPTY_CLASS(Nogroup, Nogroup);
221-
// MAKE_EMPTY_CLASS(NoOpenmp, ); // missing-in-parser
222-
// MAKE_EMPTY_CLASS(NoOpenmpRoutines, ); // missing-in-parser
223-
// MAKE_EMPTY_CLASS(NoParallelism, ); // missing-in-parser
221+
MAKE_EMPTY_CLASS(NoOpenmp, NoOpenmp);
222+
MAKE_EMPTY_CLASS(NoOpenmpRoutines, NoOpenmpRoutines);
223+
MAKE_EMPTY_CLASS(NoParallelism, NoParallelism);
224224
MAKE_EMPTY_CLASS(Notinbranch, Notinbranch);
225225
MAKE_EMPTY_CLASS(Nowait, Nowait);
226226
MAKE_EMPTY_CLASS(OmpxAttribute, OmpxAttribute);
@@ -321,7 +321,6 @@ ReductionOperator makeReductionOperator(const parser::OmpReductionOperator &inp,
321321
// --------------------------------------------------------------------
322322
// Actual clauses. Each T (where tomp::T exists in ClauseT) has its "make".
323323

324-
// Absent: missing-in-parser
325324
Absent make(const parser::OmpClause::Absent &inp,
326325
semantics::SemanticsContext &semaCtx) {
327326
llvm_unreachable("Unimplemented: absent");
@@ -450,7 +449,6 @@ Collapse make(const parser::OmpClause::Collapse &inp,
450449

451450
// Compare: empty
452451

453-
// Contains: missing-in-parser
454452
Contains make(const parser::OmpClause::Contains &inp,
455453
semantics::SemanticsContext &semaCtx) {
456454
llvm_unreachable("Unimplemented: contains");
@@ -714,7 +712,6 @@ Hint make(const parser::OmpClause::Hint &inp,
714712
return Hint{/*HintExpr=*/makeExpr(inp.v, semaCtx)};
715713
}
716714

717-
// Holds: missing-in-parser
718715
Holds make(const parser::OmpClause::Holds &inp,
719716
semantics::SemanticsContext &semaCtx) {
720717
llvm_unreachable("Unimplemented: holds");
@@ -897,24 +894,9 @@ Nontemporal make(const parser::OmpClause::Nontemporal &inp,
897894
return Nontemporal{/*List=*/makeList(inp.v, makeObjectFn(semaCtx))};
898895
}
899896

900-
// NoOpenmp: missing-in-parser
901-
NoOpenmp make(const parser::OmpClause::NoOpenmp &inp,
902-
semantics::SemanticsContext &semaCtx) {
903-
llvm_unreachable("Unimplemented: no_openmp");
904-
}
905-
906-
// NoOpenmpRoutines: missing-in-parser
907-
NoOpenmpRoutines make(const parser::OmpClause::NoOpenmpRoutines &inp,
908-
semantics::SemanticsContext &semaCtx) {
909-
llvm_unreachable("Unimplemented: no_openmp_routines");
910-
}
911-
912-
// NoParallelism: missing-in-parser
913-
NoParallelism make(const parser::OmpClause::NoParallelism &inp,
914-
semantics::SemanticsContext &semaCtx) {
915-
llvm_unreachable("Unimplemented: no_parallelism");
916-
}
917-
897+
// NoOpenmp: empty
898+
// NoOpenmpRoutines: empty
899+
// NoParallelism: empty
918900
// Notinbranch: empty
919901

920902
Novariants make(const parser::OmpClause::Novariants &inp,

flang/lib/Lower/OpenMP/Clauses.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ using At = tomp::clause::AtT<TypeTy, IdTy, ExprTy>;
175175
using Bind = tomp::clause::BindT<TypeTy, IdTy, ExprTy>;
176176
using Capture = tomp::clause::CaptureT<TypeTy, IdTy, ExprTy>;
177177
using Collapse = tomp::clause::CollapseT<TypeTy, IdTy, ExprTy>;
178-
using Contains = tomp::clause::ContainsT<TypeTy, IdTy, ExprTy>;
179178
using Compare = tomp::clause::CompareT<TypeTy, IdTy, ExprTy>;
179+
using Contains = tomp::clause::ContainsT<TypeTy, IdTy, ExprTy>;
180180
using Copyin = tomp::clause::CopyinT<TypeTy, IdTy, ExprTy>;
181181
using Copyprivate = tomp::clause::CopyprivateT<TypeTy, IdTy, ExprTy>;
182182
using Defaultmap = tomp::clause::DefaultmapT<TypeTy, IdTy, ExprTy>;

0 commit comments

Comments
 (0)