Skip to content

Commit 89eb1a5

Browse files
authored
[test][AArch64][CodeGen] Delete redundant check lines (#87965)
llvm/test/CodeGen/AArch64/elf-globals-pic.ll: Since https://reviews.llvm.org/D91734, elf-globals-static.ll test contains several `CHECK-PIC` lines. They do not seem to bring any value since there are no FileCheck run lines checking against this prefix. The right place for such tests should be elf-globals-pic.ll, which already contains check lines being deleted in this commit. Both elf-globals-pic.ll and elf-globals-static.ll were created after splitting arm64-elf-globals.ll in 6dbd0ea, and having `CHECK-PIC` lines in elf-globals-static.ll seems like an issue occurred because of git thinking that elf-globals-pic.ll is a new file and elf-global-static.ll is a rename of arm64-elf-globals.ll. llvm/test/CodeGen/AArch64/tagged-globals-pic.ll: Similar to elf-globals-pic.ll, contains unneeded `CHECK-SELECTIONDAGISEL` and `CHECK-GLOBALISEL` directives not checked by any FileCheck invocation. These directives are present in tagged-globals-static.ll. Both tests are present in the code tree since fd32639 when tagged-globals.ll was splitted into tagged-globals-{pic|static}.ll.
1 parent e1ad273 commit 89eb1a5

File tree

2 files changed

+0
-29
lines changed

2 files changed

+0
-29
lines changed

llvm/test/CodeGen/AArch64/elf-globals-static.ll

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ define i8 @test_i8(i8 %new) {
1515
; CHECK: ldrb {{w[0-9]+}}, [x[[HIREG]], :lo12:var8]
1616
; CHECK: strb {{w[0-9]+}}, [x[[HIREG]], :lo12:var8]
1717

18-
; CHECK-PIC-LABEL: test_i8:
19-
; CHECK-PIC: adrp x[[HIREG:[0-9]+]], :got:var8
20-
; CHECK-PIC: ldr x[[VAR_ADDR:[0-9]+]], [x[[HIREG]], :got_lo12:var8]
21-
; CHECK-PIC: ldrb {{w[0-9]+}}, [x[[VAR_ADDR]]]
22-
2318
; CHECK-FAST-LABEL: test_i8:
2419
; CHECK-FAST: adrp x[[HIREG:[0-9]+]], var8
2520
; CHECK-FAST: ldrb {{w[0-9]+}}, [x[[HIREG]], :lo12:var8]

llvm/test/CodeGen/AArch64/tagged-globals-pic.ll

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,6 @@ define ptr @global_addr() #0 {
3131
}
3232

3333
define i32 @global_load() #0 {
34-
; CHECK-SELECTIONDAGISEL: global_load:
35-
; CHECK-SELECTIONDAGISEL: adrp [[REG:x[0-9]+]], :pg_hi21_nc:global
36-
; CHECK-SELECTIONDAGISEL: ldr w0, [[[REG]], :lo12:global]
37-
; CHECK-SELECTIONDAGISEL: ret
38-
39-
; CHECK-GLOBALISEL: global_load:
40-
; CHECK-GLOBALISEL: adrp [[REG:x[0-9]+]], :pg_hi21_nc:global
41-
; CHECK-GLOBALISEL: movk [[REG]], #:prel_g3:global+4294967296
42-
; CHECK-GLOBALISEL: add [[REG]], [[REG]], :lo12:global
43-
; CHECK-GLOBALISEL: ldr w0, [[[REG]]]
44-
; CHECK-GLOBALISEL: ret
45-
4634
; CHECK-PIC: global_load:
4735
; CHECK-PIC: adrp [[REG:x[0-9]+]], :got:global
4836
; CHECK-PIC: ldr [[REG]], [[[REG]], :got_lo12:global]
@@ -54,18 +42,6 @@ define i32 @global_load() #0 {
5442
}
5543

5644
define void @global_store() #0 {
57-
; CHECK-SELECTIONDAGISEL: global_store:
58-
; CHECK-SELECTIONDAGISEL: adrp [[REG:x[0-9]+]], :pg_hi21_nc:global
59-
; CHECK-SELECTIONDAGISEL: str wzr, [[[REG]], :lo12:global]
60-
; CHECK-SELECTIONDAGISEL: ret
61-
62-
; CHECK-GLOBALISEL: global_store:
63-
; CHECK-GLOBALISEL: adrp [[REG:x[0-9]+]], :pg_hi21_nc:global
64-
; CHECK-GLOBALISEL: movk [[REG]], #:prel_g3:global+4294967296
65-
; CHECK-GLOBALISEL: add [[REG]], [[REG]], :lo12:global
66-
; CHECK-GLOBALISEL: str wzr, [[[REG]]]
67-
; CHECK-GLOBALISEL: ret
68-
6945
; CHECK-PIC: global_store:
7046
; CHECK-PIC: adrp [[REG:x[0-9]+]], :got:global
7147
; CHECK-PIC: ldr [[REG]], [[[REG]], :got_lo12:global]

0 commit comments

Comments
 (0)