Skip to content

Commit 8be9fd5

Browse files
committed
[libc++][syncbuf] Implements LWG3253.
Note the tests already tested this behaviour and the wording change is NFC. Implements - LWG3253 basic_syncbuf::basic_syncbuf() should not be explicit
1 parent 2acf77f commit 8be9fd5

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

libcxx/docs/Status/Cxx20Issues.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@
172172
"`3221 <https://wg21.link/LWG3221>`__","Result of ``year_month``\ arithmetic with ``months``\ is ambiguous","Belfast","|Complete|","8.0"
173173
"`3235 <https://wg21.link/LWG3235>`__","``parse``\ manipulator without abbreviation is not callable","Belfast","",""
174174
"`3246 <https://wg21.link/LWG3246>`__","What are the constraints on the template parameter of ``basic_format_arg``\ ?","Belfast","","","|format|"
175-
"`3253 <https://wg21.link/LWG3253>`__","``basic_syncbuf::basic_syncbuf()``\ should not be explicit","Belfast","",""
175+
"`3253 <https://wg21.link/LWG3253>`__","``basic_syncbuf::basic_syncbuf()``\ should not be explicit","Belfast","|Complete|","20.0"
176176
"`3245 <https://wg21.link/LWG3245>`__","Unnecessary restriction on ``'%p'``\ parse specifier","Belfast","","","|chrono|"
177177
"`3244 <https://wg21.link/LWG3244>`__","Constraints for ``Source``\ in |sect|\ [fs.path.req] insufficiently constrainty","Belfast","",""
178178
"`3241 <https://wg21.link/LWG3241>`__","``chrono-spec``\ grammar ambiguity in |sect|\ [time.format]","Belfast","|Complete|","16.0","|chrono| |format|"

libcxx/include/syncstream

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ namespace std {
4646
using streambuf_type = basic_streambuf<charT, traits>;
4747
4848
// [syncstream.syncbuf.cons], construction and destruction
49-
explicit basic_syncbuf(streambuf_type* obuf = nullptr)
49+
basic_syncbuf()
50+
: basic_syncbuf(nullptr) {}
51+
explicit basic_syncbuf(streambuf_type* obuf)
5052
: basic_syncbuf(obuf, Allocator()) {}
5153
basic_syncbuf(streambuf_type*, const Allocator&);
5254
basic_syncbuf(basic_syncbuf&&);
@@ -253,7 +255,10 @@ public:
253255

254256
// [syncstream.syncbuf.cons], construction and destruction
255257

256-
_LIBCPP_HIDE_FROM_ABI explicit basic_syncbuf(streambuf_type* __obuf = nullptr)
258+
_LIBCPP_HIDE_FROM_ABI basic_syncbuf()
259+
: basic_syncbuf(nullptr) {}
260+
261+
_LIBCPP_HIDE_FROM_ABI explicit basic_syncbuf(streambuf_type* __obuf)
257262
: basic_syncbuf(__obuf, _Allocator()) {}
258263

259264
_LIBCPP_HIDE_FROM_ABI basic_syncbuf(streambuf_type* __obuf, _Allocator const& __alloc)

0 commit comments

Comments
 (0)