Skip to content

Commit 8bf66e9

Browse files
committed
[FOLD] comment fixup
1 parent db264c7 commit 8bf66e9

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

clang/lib/Sema/SemaTemplate.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -727,6 +727,10 @@ Sema::ActOnDependentIdExpression(const CXXScopeSpec &SS,
727727
bool isAddressOfOperand,
728728
const TemplateArgumentListInfo *TemplateArgs) {
729729
if (SS.isEmpty()) {
730+
// FIXME: This codepath is only used by dependent unqualified names
731+
// (e.g. a dependent conversion-function-id, or operator= once we support
732+
// it). It doesn't quite do the right thing, and it will silently fail if
733+
// getCurrentThisType() returns null.
730734
QualType ThisType = getCurrentThisType();
731735
if (ThisType.isNull())
732736
return ExprError();
@@ -735,8 +739,8 @@ Sema::ActOnDependentIdExpression(const CXXScopeSpec &SS,
735739
Context, /*Base=*/nullptr, ThisType,
736740
/*IsArrow=*/!Context.getLangOpts().HLSL,
737741
/*OperatorLoc=*/SourceLocation(),
738-
/*QualifierLoc*/ NestedNameSpecifierLoc(), TemplateKWLoc,
739-
/*FirstQualifierFoundInScope*/ nullptr, NameInfo, TemplateArgs);
742+
/*QualifierLoc=*/NestedNameSpecifierLoc(), TemplateKWLoc,
743+
/*FirstQualifierFoundInScope=*/nullptr, NameInfo, TemplateArgs);
740744
}
741745
return BuildDependentDeclRefExpr(SS, TemplateKWLoc, NameInfo, TemplateArgs);
742746
}

0 commit comments

Comments
 (0)