[clang][Dataflow] Fix unnecessary copy in initializeFieldsWithValues (NFC)

antoniofrighetto · antoniofrighetto · commit 8c6e96d9eb35 · 2024-02-13T11:05:26.000+01:00
diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
@@ -939,7 +939,7 @@ void Environment::initializeFieldsWithValues(RecordStorageLocation &Loc,
     }
   };
 
-  for (const auto [Field, FieldLoc] : Loc.children()) {
+  for (const auto &[Field, FieldLoc] : Loc.children()) {
     assert(Field != nullptr);
     QualType FieldType = Field->getType();
 

Original file line number	Diff line number	Diff line change
`@@ -939,7 +939,7 @@ void Environment::initializeFieldsWithValues(RecordStorageLocation &Loc,`
`939`	`939`	`}`
`940`	`940`	`};`
`941`	`941`
`942`		`- for (const auto [Field, FieldLoc] : Loc.children()) {`
	`942`	`+ for (const auto &[Field, FieldLoc] : Loc.children()) {`
`943`	`943`	`assert(Field != nullptr);`
`944`	`944`	`QualType FieldType = Field->getType();`
`945`	`945`