[ADT] Avoid repeated hash lookups (NFC) (#129355)

kazutakahirata · web-flow · commit 8d1f385d4063 · 2025-02-28T21:03:35.000-08:00
diff --git a/llvm/include/llvm/ADT/SCCIterator.h b/llvm/include/llvm/ADT/SCCIterator.h
@@ -354,10 +354,10 @@ scc_member_iterator<GraphT, GT>::scc_member_iterator(
   // Walk through SortedEdges to initialize the queue, instead of using NodeInfoMap
   // to ensure an ordered deterministic push.
   for (auto *Edge : SortedEdges) {
-    if (!NodeInfoMap[Edge->Source].Visited &&
-        NodeInfoMap[Edge->Source].IncomingMSTEdges.empty()) {
+    auto &Info = NodeInfoMap[Edge->Source];
+    if (!Info.Visited && Info.IncomingMSTEdges.empty()) {
       Queue.push(Edge->Source);
-      NodeInfoMap[Edge->Source].Visited = true;
+      Info.Visited = true;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -354,10 +354,10 @@ scc_member_iterator<GraphT, GT>::scc_member_iterator(`
`354`	`354`	`// Walk through SortedEdges to initialize the queue, instead of using NodeInfoMap`
`355`	`355`	`// to ensure an ordered deterministic push.`
`356`	`356`	`for (auto *Edge : SortedEdges) {`
`357`		`- if (!NodeInfoMap[Edge->Source].Visited &&`
`358`		`- NodeInfoMap[Edge->Source].IncomingMSTEdges.empty()) {`
	`357`	`+ auto &Info = NodeInfoMap[Edge->Source];`
	`358`	`+ if (!Info.Visited && Info.IncomingMSTEdges.empty()) {`
`359`	`359`	`Queue.push(Edge->Source);`
`360`		`- NodeInfoMap[Edge->Source].Visited = true;`
	`360`	`+ Info.Visited = true;`
`361`	`361`	`}`
`362`	`362`	`}`
`363`	`363`