Skip to content

Commit 8d8f56d

Browse files
committed
[MC,AArch64] Remove unneeded STT_NOTYPE/STB_LOCAL code for mapping symbols and improve tests
1 parent cd3f48d commit 8d8f56d

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

llvm/lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,6 @@ class AArch64ELFStreamer : public MCELFStreamer {
272272
void emitMappingSymbol(StringRef Name) {
273273
auto *Symbol = cast<MCSymbolELF>(getContext().createLocalSymbol(Name));
274274
emitLabel(Symbol);
275-
Symbol->setType(ELF::STT_NOTYPE);
276-
Symbol->setBinding(ELF::STB_LOCAL);
277275
}
278276

279277
DenseMap<const MCSection *, ElfMappingSymbol> LastMappingSymbols;

llvm/test/MC/AArch64/mapping-within-section.s

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
// RUN: llvm-mc -triple=aarch64-none-linux-gnu -filetype=obj %s | llvm-nm --no-sort --special-syms - | FileCheck %s --match-full-lines
1+
# RUN: llvm-mc -triple=aarch64-none-linux-gnu -filetype=obj %s -o %t
2+
# RUN: llvm-readelf -Ss %t | FileCheck %s
23

34
.text
45
// $x at 0x0000
@@ -22,9 +23,11 @@
2223
$d:
2324
$x:
2425

25-
// CHECK: 0000000000000000 t $x
26-
// CHECK-NEXT: 0000000000000004 t $d
27-
// CHECK-NEXT: 0000000000000064 t $x
28-
// CHECK-NEXT: 0000000000000068 t $x
29-
// CHECK-NEXT: 0000000000000068 T $d
30-
// CHECK-NOT: {{.}}
26+
# CHECK: [[#TEXT:]]] .text
27+
28+
# CHECK: 1: 0000000000000000 0 NOTYPE LOCAL DEFAULT [[#TEXT]] $x
29+
# CHECK-NEXT: 2: 0000000000000004 0 NOTYPE LOCAL DEFAULT [[#TEXT]] $d
30+
# CHECK-NEXT: 3: 0000000000000064 0 NOTYPE LOCAL DEFAULT [[#TEXT]] $x
31+
# CHECK-NEXT: 4: 0000000000000068 0 NOTYPE LOCAL DEFAULT [[#TEXT]] $x
32+
# CHECK-NEXT: 5: 0000000000000068 0 NOTYPE GLOBAL DEFAULT [[#TEXT]] $d
33+
# CHECK-NOT: {{.}}

0 commit comments

Comments
 (0)