Skip to content

Commit 8da1e47

Browse files
Add missing box type volatile handling
1 parent 3426b48 commit 8da1e47

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

flang/lib/Optimizer/Dialect/FIRType.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ mlir::Type fir::parseFirType(FIROpsDialect *dialect,
136136
auto parseResult = generatedTypeParser(parser, &typeTag, genType);
137137
if (parseResult.has_value())
138138
return genType;
139-
parser.emitError(parser.getCurrentLocation(), "unknown fir type: ")
139+
parser.emitError(parser.getNameLoc(), "unknown fir type: ")
140140
<< typeTag;
141141
return {};
142142
}
@@ -680,9 +680,9 @@ mlir::Type changeElementType(mlir::Type type, mlir::Type newElementType,
680680
.Case<fir::BoxType>([&](fir::BoxType t) -> mlir::Type {
681681
mlir::Type newInnerType =
682682
changeElementType(t.getEleTy(), newElementType, false);
683+
// TODO: volatility on class types
683684
if (turnBoxIntoClass)
684-
return fir::ClassType::get(
685-
newInnerType); // TODO: volatility on class types
685+
return fir::ClassType::get(newInnerType);
686686
return fir::BoxType::get(newInnerType, t.isVolatile());
687687
})
688688
.Default([&](mlir::Type t) -> mlir::Type {

0 commit comments

Comments
 (0)