Skip to content

Commit 8e09f13

Browse files
[OrcJITTests] Fix warning: suggest explicit braces to avoid ambiguous 'else' (NFC)
Likely related to platform-specific expansion of gtest macros: ``` llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp:1276:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] ```
1 parent 626d0fa commit 8e09f13

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

llvm/unittests/ExecutionEngine/JITLink/EHFrameSupportTests.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,9 @@ TEST(EHFrameCFIBlockInspector, BasicSuccessCase) {
185185
if (CFIBI.isCIE()) {
186186
CIEs.push_back(B);
187187
// If this CIE has an edge, check that getPersonalityEdge returns it.
188-
if (B->edges_size() != 0)
188+
if (B->edges_size() != 0) {
189189
EXPECT_TRUE(!!CFIBI.getPersonalityEdge());
190+
}
190191
}
191192
}
192193
ASSERT_EQ(CIEs.size(), 2U);

llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,8 +1193,9 @@ TEST_F(CoreAPIsStandardTest, SimpleAsynchronousGeneratorTest) {
11931193
[&](Expected<SymbolMap> Result) {
11941194
LookupCompleted = true;
11951195
EXPECT_THAT_EXPECTED(Result, Succeeded());
1196-
if (Result)
1196+
if (Result) {
11971197
EXPECT_EQ(*Result, SymbolMap({{Foo, FooSym}}));
1198+
}
11981199
},
11991200
NoDependenciesToRegister);
12001201

@@ -1228,8 +1229,9 @@ TEST_F(CoreAPIsStandardTest, BlockedGeneratorAutoSuspensionTest) {
12281229
[&](Expected<SymbolMap> Result) {
12291230
Lookup1Completed = true;
12301231
EXPECT_THAT_EXPECTED(Result, Succeeded());
1231-
if (Result)
1232+
if (Result) {
12321233
EXPECT_EQ(*Result, SymbolMap({{Foo, FooSym}}));
1234+
}
12331235
},
12341236
NoDependenciesToRegister);
12351237

@@ -1256,8 +1258,9 @@ TEST_F(CoreAPIsStandardTest, BlockedGeneratorAutoSuspensionTest) {
12561258
[&](Expected<SymbolMap> Result) {
12571259
Lookup2Completed = true;
12581260
EXPECT_THAT_EXPECTED(Result, Succeeded());
1259-
if (Result)
1261+
if (Result) {
12601262
EXPECT_EQ(*Result, SymbolMap({{Bar, BarSym}}));
1263+
}
12611264
},
12621265
NoDependenciesToRegister);
12631266

@@ -1273,8 +1276,9 @@ TEST_F(CoreAPIsStandardTest, BlockedGeneratorAutoSuspensionTest) {
12731276
[&](Expected<SymbolMap> Result) {
12741277
Lookup3Completed = true;
12751278
EXPECT_THAT_EXPECTED(Result, Succeeded());
1276-
if (Result)
1279+
if (Result) {
12771280
EXPECT_EQ(*Result, SymbolMap({{Bar, BarSym}}));
1281+
}
12781282
},
12791283
NoDependenciesToRegister);
12801284

@@ -1288,8 +1292,9 @@ TEST_F(CoreAPIsStandardTest, BlockedGeneratorAutoSuspensionTest) {
12881292
[&](Expected<SymbolMap> Result) {
12891293
Lookup4Completed = true;
12901294
EXPECT_THAT_EXPECTED(Result, Succeeded());
1291-
if (Result)
1295+
if (Result) {
12921296
EXPECT_EQ(*Result, SymbolMap({{Baz, BazSym}}));
1297+
}
12931298
},
12941299
NoDependenciesToRegister);
12951300

@@ -1314,8 +1319,9 @@ TEST_F(CoreAPIsStandardTest, BlockedGeneratorAutoSuspensionTest) {
13141319
EXPECT_NE(G.Lookup, std::nullopt);
13151320

13161321
// Check that the most recently captured lookup is lookup 4 (for baz).
1317-
if (G.Lookup)
1322+
if (G.Lookup) {
13181323
EXPECT_EQ(G.Lookup->Names.begin()->first, Baz);
1324+
}
13191325

13201326
cantFail(JD.define(absoluteSymbols({{Baz, BazSym}})));
13211327
G.takeLookup().LS.continueLookup(Error::success());

0 commit comments

Comments
 (0)