Skip to content

Commit 8ee6c0e

Browse files
committed
[MC] Remove isThumbFunc special case
The special case from 9746286 (2011) seems irrelevant nowadays. It is actually incorrect because GNU assembler does not set the least significant bit for `.long thumb - .`.
1 parent 894140b commit 8ee6c0e

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

llvm/lib/MC/MCExpr.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -606,11 +606,6 @@ static void AttemptToFoldSymbolOffsetDifference(
606606
return;
607607

608608
auto FinalizeFolding = [&]() {
609-
// Pointers to Thumb symbols need to have their low-bit set to allow
610-
// for interworking.
611-
if (Asm->isThumbFunc(&SA))
612-
Addend |= 1;
613-
614609
// If symbol is labeled as micromips, we set low-bit to ensure
615610
// correct offset in .gcc_except_table
616611
if (Asm->getBackend().isMicroMips(&SA))

0 commit comments

Comments
 (0)