Skip to content

Commit 8f9da30

Browse files
committed
Address reviewer comments.
1 parent e75d478 commit 8f9da30

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

flang/lib/Lower/OpenMP/OpenMP.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3143,8 +3143,9 @@ genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
31433143
mapperNameStr, *varType.declTypeSpec->derivedTypeSpec().GetScope());
31443144
}
31453145

3146-
// Save insert point just after the DeclMapperOp.
3147-
mlir::OpBuilder::InsertPoint insPt = firOpBuilder.saveInsertionPoint();
3146+
// Save current insertion point before moving to the module scope to create
3147+
// the DeclareMapperOp
3148+
mlir::OpBuilder::InsertionGuard guard(firOpBuilder);
31483149

31493150
firOpBuilder.setInsertionPointToStart(converter.getModuleOp().getBody());
31503151
auto mlirType = converter.genType(varType.declTypeSpec->derivedTypeSpec());
@@ -3164,9 +3165,6 @@ genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
31643165
ClauseProcessor cp(converter, semaCtx, clauses);
31653166
cp.processMap(loc, stmtCtx, clauseOps);
31663167
firOpBuilder.create<mlir::omp::DeclareMapperInfoOp>(loc, clauseOps.mapVars);
3167-
3168-
// Restore the insert point to just after the DeclareMapperOp.
3169-
firOpBuilder.restoreInsertionPoint(insPt);
31703168
}
31713169

31723170
static void

0 commit comments

Comments
 (0)