Skip to content

Commit 906316e

Browse files
committed
[lldb] More descriptive name for register flags logging functions
This was requested on a review for enum code that added new log functions.
1 parent 34de7fd commit 906316e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lldb/include/lldb/Target/RegisterFlags.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class RegisterFlags {
8989
unsigned GetEnd() const { return m_end; }
9090
const FieldEnum *GetEnum() const { return m_enum_type; }
9191
bool Overlaps(const Field &other) const;
92-
void log(Log *log) const;
92+
void DumpToLog(Log *log) const;
9393

9494
/// Return the number of bits between this field and the other, that are not
9595
/// covered by either field.
@@ -158,7 +158,7 @@ class RegisterFlags {
158158
const std::vector<Field> &GetFields() const { return m_fields; }
159159
const std::string &GetID() const { return m_id; }
160160
unsigned GetSize() const { return m_size; }
161-
void log(Log *log) const;
161+
void DumpToLog(Log *log) const;
162162

163163
/// Produce a text table showing the layout of all the fields. Unnamed/padding
164164
/// fields will be included, with only their positions shown.

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4383,7 +4383,7 @@ bool ParseRegisters(
43834383

43844384
ParseFlags(feature_node, registers_flags_types);
43854385
for (const auto &flags : registers_flags_types)
4386-
flags.second->log(log);
4386+
flags.second->DumpToLog(log);
43874387

43884388
feature_node.ForEachChildElementWithName(
43894389
"reg",

lldb/source/Target/RegisterFlags.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ RegisterFlags::Field::Field(std::string name, unsigned start, unsigned end,
4747
}
4848
}
4949

50-
void RegisterFlags::Field::log(Log *log) const {
50+
void RegisterFlags::Field::DumpToLog(Log *log) const {
5151
LLDB_LOG(log, " Name: \"{0}\" Start: {1} End: {2}", m_name.c_str(), m_start,
5252
m_end);
5353
}
@@ -156,10 +156,10 @@ RegisterFlags::RegisterFlags(std::string id, unsigned size,
156156
SetFields(fields);
157157
}
158158

159-
void RegisterFlags::log(Log *log) const {
159+
void RegisterFlags::DumpToLog(Log *log) const {
160160
LLDB_LOG(log, "ID: \"{0}\" Size: {1}", m_id.c_str(), m_size);
161161
for (const Field &field : m_fields)
162-
field.log(log);
162+
field.DumpToLog(log);
163163
}
164164

165165
static StreamString FormatCell(const StreamString &content,

0 commit comments

Comments
 (0)