Skip to content

Commit 9124fa5

Browse files
committed
Fix broken HUGE_VALF macro in llvm-c/DataTypes.h
Commit 3a29393 removes the cmath/math.h includes from the DataTypes.h header to speed up parsing. However the DataTypes.h header was using this header to get the macro `HUGE_VAL` for its own `HUGE_VALF` macro definition. Now the macro instead just expands into a plain `HUGE_VAL` token which leads to compiler errors unless `math.h` was previously included by the including source file. It also leads to compiler warnings with enabled module builds which point out this inconsistency. The correct way to fix this seems to be to just remove HUGE_VALF from the header. llvm-c is not referencing that macro from what I can see and users probably should just include the math headers if they need it (or define it on their own for really old C versions). Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D83761
1 parent f0699d9 commit 9124fa5

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

llvm/include/llvm-c/DataTypes.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,4 @@ typedef signed int ssize_t;
7777
# define UINT64_MAX 0xffffffffffffffffULL
7878
#endif
7979

80-
#ifndef HUGE_VALF
81-
#define HUGE_VALF (float)HUGE_VAL
82-
#endif
83-
8480
#endif /* LLVM_C_DATATYPES_H */

0 commit comments

Comments
 (0)