[DAG] AddNodeIDCustom - call ShuffleVectorSDNode::getMask once instead of repeated getMaskElt calls.

RKSimon · RKSimon · commit 912cdd217978 · 2024-01-31T12:01:01.000Z
Use a simpler for-range loop to append all shuffle mask elements
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -909,10 +909,9 @@ static void AddNodeIDCustom(FoldingSetNodeID &ID, const SDNode *N) {
     break;
   }
   case ISD::VECTOR_SHUFFLE: {
-    const ShuffleVectorSDNode *SVN = cast<ShuffleVectorSDNode>(N);
-    for (unsigned i = 0, e = N->getValueType(0).getVectorNumElements();
-         i != e; ++i)
-      ID.AddInteger(SVN->getMaskElt(i));
+    ArrayRef<int> Mask = cast<ShuffleVectorSDNode>(N)->getMask();
+    for (int M : Mask)
+      ID.AddInteger(M);
     break;
   }
   case ISD::TargetBlockAddress:

Original file line number	Diff line number	Diff line change
`@@ -909,10 +909,9 @@ static void AddNodeIDCustom(FoldingSetNodeID &ID, const SDNode *N) {`
`909`	`909`	`break;`
`910`	`910`	`}`
`911`	`911`	`case ISD::VECTOR_SHUFFLE: {`
`912`		`- const ShuffleVectorSDNode *SVN = cast<ShuffleVectorSDNode>(N);`
`913`		`- for (unsigned i = 0, e = N->getValueType(0).getVectorNumElements();`
`914`		`- i != e; ++i)`
`915`		`- ID.AddInteger(SVN->getMaskElt(i));`
	`912`	`+ ArrayRef<int> Mask = cast<ShuffleVectorSDNode>(N)->getMask();`
	`913`	`+ for (int M : Mask)`
	`914`	`+ ID.AddInteger(M);`
`916`	`915`	`break;`
`917`	`916`	`}`
`918`	`917`	`case ISD::TargetBlockAddress:`