Skip to content

Commit 91d9940

Browse files
committed
Respond to some review comments
1 parent 51f9e51 commit 91d9940

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13132,6 +13132,9 @@ SDValue SITargetLowering::performXorCombine(SDNode *N,
1313213132
SDValue LHS = N->getOperand(0);
1313313133
SDValue RHS = N->getOperand(1);
1313413134

13135+
// Fold the fneg of a vselect into the v2 vselect operands.
13136+
// xor (vselect c, a, b), 0x80000000 ->
13137+
// bitcast (vselect c, (fneg (bitcast a)), (fneg (bitcast b)))
1313513138
if (VT == MVT::v2i32 && LHS.getNumOperands() > 1) {
1313613139

1313713140
const ConstantSDNode *CRHS0 = dyn_cast<ConstantSDNode>(RHS.getOperand(0));

llvm/test/CodeGen/AMDGPU/or.ll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
; RUN: llc -amdgpu-scalarize-global-loads=true -mtriple=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=GFX8S %s
66
; RUN: llc -amdgpu-scalarize-global-loads=false -mtriple=r600 -mcpu=redwood < %s | FileCheck -check-prefix=EG %s
77

8-
;; Added tests with "-amdgpu-scalarize-global-loads=true" to allow the generation of s_or_b64, particularly in the v2i32 case. See SWDEV-517886.
9-
;; Also removed the previously unused "GCN" check-prefixes from the test.
10-
118
define amdgpu_kernel void @or_v2i32(ptr addrspace(1) %out, ptr addrspace(1) %in) {
129
; GFX6-LABEL: or_v2i32:
1310
; GFX6: ; %bb.0:

0 commit comments

Comments
 (0)