Skip to content

Commit 9277ce7

Browse files
committed
[DebugInfo] Remove unnecessary <string> include dependency from DebugInfo headers. NFC.
At most these use the StringRef/Twine wrappers and don't have any implicit uses of std::string. Move the include down to any cpp implementation where std::string is actually used.
1 parent 5df4849 commit 9277ce7

File tree

6 files changed

+2
-8
lines changed

6 files changed

+2
-8
lines changed

llvm/include/llvm/DebugInfo/CodeView/CodeViewError.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
#include "llvm/Support/Error.h"
1313

14-
#include <string>
15-
1614
namespace llvm {
1715
namespace codeview {
1816
enum class cv_error_code {

llvm/include/llvm/DebugInfo/GSYM/GsymCreator.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include <functional>
1313
#include <memory>
1414
#include <mutex>
15-
#include <string>
1615
#include <thread>
1716

1817
#include "llvm/ADT/ArrayRef.h"

llvm/include/llvm/DebugInfo/GSYM/GsymReader.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#ifndef LLVM_DEBUGINFO_GSYM_GSYMREADER_H
1010
#define LLVM_DEBUGINFO_GSYM_GSYMREADER_H
1111

12-
1312
#include "llvm/ADT/ArrayRef.h"
1413
#include "llvm/DebugInfo/GSYM/FileEntry.h"
1514
#include "llvm/DebugInfo/GSYM/FunctionInfo.h"
@@ -19,11 +18,9 @@
1918
#include "llvm/Support/DataExtractor.h"
2019
#include "llvm/Support/Endian.h"
2120
#include "llvm/Support/ErrorOr.h"
22-
2321
#include <inttypes.h>
2422
#include <memory>
2523
#include <stdint.h>
26-
#include <string>
2724
#include <vector>
2825

2926
namespace llvm {

llvm/include/llvm/DebugInfo/MSF/MSFError.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
#include "llvm/Support/Error.h"
1313

14-
#include <string>
15-
1614
namespace llvm {
1715
namespace msf {
1816
enum class msf_error_code {

llvm/lib/DebugInfo/CodeView/CodeViewError.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "llvm/DebugInfo/CodeView/CodeViewError.h"
1010
#include "llvm/Support/ErrorHandling.h"
1111
#include "llvm/Support/ManagedStatic.h"
12+
#include <string>
1213

1314
using namespace llvm;
1415
using namespace llvm::codeview;

llvm/lib/DebugInfo/MSF/MSFError.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "llvm/DebugInfo/MSF/MSFError.h"
1010
#include "llvm/Support/ErrorHandling.h"
1111
#include "llvm/Support/ManagedStatic.h"
12+
#include <string>
1213

1314
using namespace llvm;
1415
using namespace llvm::msf;

0 commit comments

Comments
 (0)