Simplying, formatting and adding doc.

Author: htyu

mlir/include/mlir/Dialect/Arith/Utils/Utils.h

@@ -93,6 +93,9 @@ Value createScalarOrSplatConstant(OpBuilder &builder, Location loc, Type type,
                                   int64_t value);
 Value createScalarOrSplatConstant(OpBuilder &builder, Location loc, Type type,
                                   const APFloat &value);
+
+/// Create a constant of type `type` at location `loc` whose value is `value`.
+/// This works for integer type or the index type only.
 Value createIntOrIndexConstant(OpBuilder &builder, Location loc, Type type,
                                int64_t value);
 

mlir/lib/Dialect/Arith/Utils/Utils.cpp

@@ -306,10 +306,7 @@ Value mlir::createIntOrIndexConstant(OpBuilder &b, Location loc, Type type,
                                      int64_t value) {
   assert(type.isIntOrIndex() &&
          "unexpected type other than integers and index");
-  if (type.isIndex())
-    return b.create<arith::ConstantIndexOp>(loc, value);
-  else
-    return b.create<arith::ConstantOp>(loc, b.getIntegerAttr(type, value));
+  return b.create<arith::ConstantOp>(loc, b.getIntegerAttr(type, value));
 }
 
 Type mlir::getType(OpFoldResult ofr) {

mlir/lib/Dialect/SCF/Utils/Utils.cpp

@@ -391,7 +391,8 @@ LogicalResult mlir::loopUnrollByFactor(
     generateEpilogueLoop = upperBoundUnrolledCst < ubCst;
     if (generateEpilogueLoop)
       upperBoundUnrolled = createIntOrIndexConstant(
-          boundsBuilder, loc, forOp.getUpperBound().getType(), upperBoundUnrolledCst);
+          boundsBuilder, loc, forOp.getUpperBound().getType(),
+          upperBoundUnrolledCst);
     else
       upperBoundUnrolled = forOp.getUpperBound();