Skip to content

Commit 92f4f0b

Browse files
authored
[flang][NFC] Use tablegen to create simplifyRegionLite constructor (#89957)
This is a ModuleOp pass anyway so it doesn't need to be run on particular top level operations.
1 parent 7bc0177 commit 92f4f0b

File tree

4 files changed

+3
-9
lines changed

4 files changed

+3
-9
lines changed

flang/include/flang/Optimizer/Transforms/Passes.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ std::unique_ptr<mlir::Pass> createLoopVersioningPass();
6868
std::unique_ptr<mlir::Pass>
6969
createMemoryAllocationPass(bool dynOnHeap, std::size_t maxStackSize);
7070
std::unique_ptr<mlir::Pass> createAnnotateConstantOperandsPass();
71-
std::unique_ptr<mlir::Pass> createSimplifyRegionLitePass();
7271
std::unique_ptr<mlir::Pass> createAlgebraicSimplificationPass();
7372
std::unique_ptr<mlir::Pass>
7473
createAlgebraicSimplificationPass(const mlir::GreedyRewriteConfig &config);

flang/include/flang/Optimizer/Transforms/Passes.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ def SimplifyRegionLite : Pass<"simplify-region-lite", "mlir::ModuleOp"> {
286286
let description = [{
287287
Run region DCE and erase unreachable blocks in regions.
288288
}];
289-
let constructor = "::fir::createSimplifyRegionLitePass()";
290289
}
291290

292291
def AlgebraicSimplification : Pass<"flang-algebraic-simplification"> {

flang/include/flang/Tools/CLOptions.inc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ inline void createDefaultFIROptimizerPassPipeline(
245245
fir::addAVC(pm, pc.OptLevel);
246246
addNestedPassToAllTopLevelOperations(pm, fir::createCharacterConversion);
247247
pm.addPass(mlir::createCanonicalizerPass(config));
248-
pm.addPass(fir::createSimplifyRegionLitePass());
248+
pm.addPass(fir::createSimplifyRegionLite());
249249
if (pc.OptLevel.isOptimizingForSpeed()) {
250250
// These passes may increase code size.
251251
pm.addPass(fir::createSimplifyIntrinsicsPass());
@@ -267,7 +267,7 @@ inline void createDefaultFIROptimizerPassPipeline(
267267
llvm::StringMap<mlir::OpPassManager> pipelines;
268268
pm.addPass(mlir::createInlinerPass(
269269
pipelines, addCanonicalizerPassWithoutRegionSimplification));
270-
pm.addPass(fir::createSimplifyRegionLitePass());
270+
pm.addPass(fir::createSimplifyRegionLite());
271271
pm.addPass(mlir::createCSEPass());
272272

273273
// Polymorphic types
@@ -281,7 +281,7 @@ inline void createDefaultFIROptimizerPassPipeline(
281281
pm.addPass(mlir::createConvertSCFToCFPass());
282282

283283
pm.addPass(mlir::createCanonicalizerPass(config));
284-
pm.addPass(fir::createSimplifyRegionLitePass());
284+
pm.addPass(fir::createSimplifyRegionLite());
285285
pm.addPass(mlir::createCSEPass());
286286
}
287287

flang/lib/Optimizer/Transforms/SimplifyRegionLite.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,3 @@ void SimplifyRegionLitePass::runOnOperation() {
4545
(void)mlir::eraseUnreachableBlocks(rewriter, regions);
4646
(void)mlir::runRegionDCE(rewriter, regions);
4747
}
48-
49-
std::unique_ptr<mlir::Pass> fir::createSimplifyRegionLitePass() {
50-
return std::make_unique<SimplifyRegionLitePass>();
51-
}

0 commit comments

Comments
 (0)