Skip to content

Commit 93312be

Browse files
committed
remove passing tests from being XFAILED, change some race conditions back to UNSUPPORTED
1 parent 1228dc1 commit 93312be

File tree

7 files changed

+3
-20
lines changed

7 files changed

+3
-20
lines changed

libcxx/test/std/language.support/support.rtti/type.info/type_info.equal.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212

1313
// UNSUPPORTED: no-rtti
1414

15-
// When we build for Windows on top of the VC runtime, `typeinfo::operator==` may not
16-
// be `constexpr` (depending on the version of the VC runtime). So this test can fail.
17-
// XFAIL: target={{.+}}-windows-msvc && !libcpp-no-vcruntime
18-
1915
#include <typeinfo>
2016
#include <cassert>
2117

libcxx/test/std/thread/futures/futures.async/async_race.38682.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
// There's currently no release of OS X whose dylib contains the patch for
1313
// PR38682. Since the fix for future<void> is in the dylib, this test may fail.
14-
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
14+
// UNSUPPORTED: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
1515

1616
// This test is designed to cause and allow TSAN to detect a race condition
1717
// in std::async, as reported in https://llvm.org/PR38682.

libcxx/test/std/thread/futures/futures.future_error/what.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313
//
1414
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{9|10|11}}
1515

16-
// VC Runtime's std::exception::what() method is not marked as noexcept, so
17-
// this fails.
18-
// XFAIL: target=x86_64-pc-windows-msvc && !libcpp-no-vcruntime
19-
2016
// <future>
2117
//
2218
// class future_error

libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
// The fix of LWG3343 is done in the dylib. That means Apple backdeployment
1515
// targets remain broken. Due to the nature of the test, testing on a broken
1616
// system does not guarantee that the test fails, so the test can't use XFAIL.
17-
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{.+}}
18-
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx11.{{.+}}
17+
// UNSUPPORTED: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{.+}}
18+
// UNSUPPORTED: stdlib=apple-libc++ && target={{.+}}-apple-macosx11.{{.+}}
1919

2020
// This is a regression test for LWG3343.
2121
//

libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
// This version runs the test when the platform has Unicode support.
1212
// UNSUPPORTED: libcpp-has-no-unicode
1313

14-
// TODO FMT Investigate Windows issues.
15-
// XFAIL: target={{.+}}-windows-gnu
16-
1714
// TODO FMT This test should not require std::to_chars(floating-point)
1815
// XFAIL: availability-fp_to_chars-missing
1916

libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.pass.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77

88
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
99

10-
// TODO FMT Investigate why this fails.
11-
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx{{10.9|10.10|10.11|10.12|10.13|10.14|10.15|11.0|12.0}}
12-
1310
// <format>
1411

1512
// template<ranges::input_range R, class charT>

libcxx/test/std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77

88
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
99

10-
// TODO FMT Investigate why this fails.
11-
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx{{10.9|10.10|10.11|10.12|10.13|10.14|10.15|11.0|12.0}}
12-
1310
// <format>
1411

1512
// template<ranges::input_range R, class charT>

0 commit comments

Comments
 (0)