Skip to content

Commit 93efa2b

Browse files
Revert "[OpenMP] Fix two usm tests for amdgpus." (#77983)
Reverts #77851
1 parent 4c41449 commit 93efa2b

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

openmp/libomptarget/test/lit.cfg

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,7 @@ if config.libomptarget_current_target.startswith('nvptx'):
117117
# If the architecture is invalid, assume it is supported.
118118
supports_unified_shared_memory = True
119119
if config.libomptarget_current_target.startswith('amdgcn'):
120-
if not (config.amdgpu_test_arch == "gfx908" or
121-
config.amdgpu_test_arch == "gfx90a" or
122-
config.amdgpu_test_arch == "gfx942") :
123-
supports_unified_shared_memory = False
120+
supports_unified_shared_memory = False
124121
if supports_unified_shared_memory:
125122
config.available_features.add('unified_shared_memory')
126123

openmp/libomptarget/test/lit.site.cfg.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ config.test_extra_flags = "@OPENMP_TEST_FLAGS@"
1010
config.cuda_path = "@CUDA_TOOLKIT_ROOT_DIR@"
1111
config.cuda_libdir = "@CUDA_LIBDIR@"
1212
config.cuda_test_arch = "@LIBOMPTARGET_DEP_CUDA_ARCH@"
13-
config.amdgpu_test_arch = "@LIBOMPTARGET_AMDGPU_DETECTED_ARCH_LIST@"
1413
config.libomptarget_obj_root = "@CMAKE_CURRENT_BINARY_DIR@/@CURRENT_TARGET@"
1514
config.library_dir = "@LIBOMPTARGET_LIBRARY_DIR@"
1615
config.llvm_library_dir = "@LIBOMPTARGET_LLVM_LIBRARY_DIR@"

openmp/libomptarget/test/unified_shared_memory/api.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
// RUN: %libomptarget-compile-generic
2-
// RUN: env HSA_XNACK=1 \
3-
// RUN: %libomptarget-run-generic | %fcheck-generic
1+
// RUN: %libomptarget-compile-run-and-check-generic
42
// XFAIL: nvptx64-nvidia-cuda
53
// XFAIL: nvptx64-nvidia-cuda-LTO
64

5+
// Fails on amdgpu with error: GPU Memory Error
6+
// UNSUPPORTED: amdgcn-amd-amdhsa
7+
78
#include <omp.h>
89
#include <stdio.h>
910

openmp/libomptarget/test/unified_shared_memory/close_enter_exit.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
// RUN: %libomptarget-compile-generic
2-
// RUN: env HSA_XNACK=1 \
3-
// RUN: %libomptarget-run-generic | %fcheck-generic
1+
// RUN: %libomptarget-compile-run-and-check-generic
42

53
// REQUIRES: unified_shared_memory
64
// UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
75

6+
// Fails on amdgpu with error: GPU Memory Error
87
// Fails on nvptx with error: an illegal memory access was encountered
8+
// XFAIL: amdgcn-amd-amdhsa
99
// XFAIL: nvptx64-nvidia-cuda
1010
// XFAIL: nvptx64-nvidia-cuda-LTO
1111

0 commit comments

Comments
 (0)