Skip to content

Commit 93f9fb2

Browse files
committed
[RISCV] Rename Binary->Ternary and Unary->Binary for some cases in RISCVInstrInfoZvk.td. NFC
For instructions that use vd as an input and not just a merge, we weren't including it in the operand count for the naming.
1 parent 3e664ac commit 93f9fb2

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ class ZvkMxSet<string vd_lmul> {
180180
!eq(vd_lmul, "MF8") : [V_MF8]);
181181
}
182182

183-
class VPseudoUnaryNoMask_Zvk<DAGOperand RetClass, VReg OpClass> :
183+
class VPseudoBinaryNoMask_Zvk<DAGOperand RetClass, VReg OpClass> :
184184
Pseudo<(outs RetClass:$rd_wb),
185185
(ins RetClass:$rd, OpClass:$rs2, AVL:$vl, ixlenimm:$sew, ixlenimm:$policy), []>,
186186
RISCVVPseudo {
@@ -194,9 +194,9 @@ class VPseudoUnaryNoMask_Zvk<DAGOperand RetClass, VReg OpClass> :
194194
let BaseInstr = !cast<Instruction>(PseudoToVInst<NAME>.VInst);
195195
}
196196

197-
class VPseudoBinaryNoMask_Zvk<VReg RetClass,
198-
VReg Op1Class,
199-
DAGOperand Op2Class> :
197+
class VPseudoTernaryNoMask_Zvk<VReg RetClass,
198+
VReg Op1Class,
199+
DAGOperand Op2Class> :
200200
Pseudo<(outs RetClass:$rd_wb),
201201
(ins RetClass:$rd, Op1Class:$rs2, Op2Class:$rs1,
202202
AVL:$vl, ixlenimm:$sew, ixlenimm:$policy), []>,
@@ -211,24 +211,24 @@ class VPseudoBinaryNoMask_Zvk<VReg RetClass,
211211
let BaseInstr = !cast<Instruction>(PseudoToVInst<NAME>.VInst);
212212
}
213213

214-
multiclass VPseudoBinaryNoMask_Zvk<VReg RetClass,
214+
multiclass VPseudoTernaryNoMask_Zvk<VReg RetClass,
215215
VReg Op1Class,
216216
DAGOperand Op2Class,
217217
LMULInfo MInfo> {
218218
let VLMul = MInfo.value in
219-
def "_" # MInfo.MX : VPseudoBinaryNoMask_Zvk<RetClass, Op1Class, Op2Class>;
219+
def "_" # MInfo.MX : VPseudoTernaryNoMask_Zvk<RetClass, Op1Class, Op2Class>;
220220
}
221221

222-
multiclass VPseudoUnaryV_V_NoMask_Zvk<LMULInfo m> {
222+
multiclass VPseudoBinaryV_V_NoMask_Zvk<LMULInfo m> {
223223
let VLMul = m.value in {
224-
def "_VV_" # m.MX : VPseudoUnaryNoMask_Zvk<m.vrclass, m.vrclass>;
224+
def "_VV_" # m.MX : VPseudoBinaryNoMask_Zvk<m.vrclass, m.vrclass>;
225225
}
226226
}
227227

228-
multiclass VPseudoUnaryV_S_NoMask_Zvk<LMULInfo m> {
228+
multiclass VPseudoBinaryV_S_NoMask_Zvk<LMULInfo m> {
229229
let VLMul = m.value in
230230
foreach vs2_lmul = ZvkMxSet<m.MX>.vs2_lmuls in
231-
def "_VS_" # m.MX # "_" # vs2_lmul.MX : VPseudoUnaryNoMask_Zvk<m.vrclass, vs2_lmul.vrclass>;
231+
def "_VS_" # m.MX # "_" # vs2_lmul.MX : VPseudoBinaryNoMask_Zvk<m.vrclass, vs2_lmul.vrclass>;
232232
}
233233

234234
multiclass VPseudoVALU_V_NoMask_Zvk {
@@ -237,7 +237,7 @@ multiclass VPseudoVALU_V_NoMask_Zvk {
237237
defvar WriteVIALUV_MX = !cast<SchedWrite>("WriteVIALUV_" # mx);
238238
defvar ReadVIALUV_MX = !cast<SchedRead>("ReadVIALUV_" # mx);
239239

240-
defm "" : VPseudoUnaryV_V_NoMask_Zvk<m>,
240+
defm "" : VPseudoBinaryV_V_NoMask_Zvk<m>,
241241
Sched<[WriteVIALUV_MX, ReadVIALUV_MX, ReadVIALUV_MX, ReadVMask]>;
242242
}
243243
}
@@ -248,7 +248,7 @@ multiclass VPseudoVALU_S_NoMask_Zvk {
248248
defvar WriteVIALUV_MX = !cast<SchedWrite>("WriteVIALUV_" # mx);
249249
defvar ReadVIALUV_MX = !cast<SchedRead>("ReadVIALUV_" # mx);
250250

251-
defm "" : VPseudoUnaryV_S_NoMask_Zvk<m>,
251+
defm "" : VPseudoBinaryV_S_NoMask_Zvk<m>,
252252
Sched<[WriteVIALUV_MX, ReadVIALUV_MX, ReadVIALUV_MX, ReadVMask]>;
253253
}
254254
}
@@ -262,7 +262,7 @@ multiclass VPseudoVALU_VV_NoMask_Zvk {
262262
defvar WriteVIALUV_MX = !cast<SchedWrite>("WriteVIALUV_" # mx);
263263
defvar ReadVIALUV_MX = !cast<SchedRead>("ReadVIALUV_" # mx);
264264

265-
defm _VV : VPseudoBinaryNoMask_Zvk<m.vrclass, m.vrclass, m.vrclass, m>,
265+
defm _VV : VPseudoTernaryNoMask_Zvk<m.vrclass, m.vrclass, m.vrclass, m>,
266266
Sched<[WriteVIALUV_MX, ReadVIALUV_MX, ReadVIALUV_MX, ReadVMask]>;
267267
}
268268
}
@@ -273,7 +273,7 @@ multiclass VPseudoVALU_VI_NoMask_Zvk {
273273
defvar WriteVIALUV_MX = !cast<SchedWrite>("WriteVIALUV_" # mx);
274274
defvar ReadVIALUV_MX = !cast<SchedRead>("ReadVIALUV_" # mx);
275275

276-
defm _VI : VPseudoBinaryNoMask_Zvk<m.vrclass, m.vrclass, uimm5, m>,
276+
defm _VI : VPseudoTernaryNoMask_Zvk<m.vrclass, m.vrclass, uimm5, m>,
277277
Sched<[WriteVIALUV_MX, ReadVIALUV_MX, ReadVIALUV_MX, ReadVMask]>;
278278
}
279279
}

0 commit comments

Comments
 (0)