Review comments

sudonatalie · sudonatalie · commit 948dd7dede68 · 2024-01-17T18:58:31.000Z
diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp
@@ -4257,13 +4257,13 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts, ArgList &Args,
           Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
               << ShaderModel << T.getOSName() << T.str();
         }
-      }
-
-      if (T.isSPIRVLogical()) {
+      } else if (T.isSPIRVLogical()) {
         if (!T.isVulkanOS() || T.getVulkanVersion() == VersionTuple(0)) {
           Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
               << VulkanEnv << T.getOSName() << T.str();
         }
+      } else {
+        llvm_unreachable();
       }
     } else
       Diags.Report(diag::err_drv_hlsl_unsupported_target) << T.str();

Original file line number	Diff line number	Diff line change
`@@ -4257,13 +4257,13 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts, ArgList &Args,`
`4257`	`4257`	`Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)`
`4258`	`4258`	`<< ShaderModel << T.getOSName() << T.str();`
`4259`	`4259`	`}`
`4260`		`- }`
`4261`		`-`
`4262`		`- if (T.isSPIRVLogical()) {`
	`4260`	`+ } else if (T.isSPIRVLogical()) {`
`4263`	`4261`	`if (!T.isVulkanOS() \|\| T.getVulkanVersion() == VersionTuple(0)) {`
`4264`	`4262`	`Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)`
`4265`	`4263`	`<< VulkanEnv << T.getOSName() << T.str();`
`4266`	`4264`	`}`
	`4265`	`+ } else {`
	`4266`	`+ llvm_unreachable();`
`4267`	`4267`	`}`
`4268`	`4268`	`} else`
`4269`	`4269`	`Diags.Report(diag::err_drv_hlsl_unsupported_target) << T.str();`