Add dtor, amend Jonas's feedback on docstrings and formatting

Author: Jlalond

lldb/bindings/interface/SBProgressDocstrings.i

@@ -11,4 +11,4 @@ The Progress class helps make sure that progress is correctly reported
 and will always send an initial progress update, updates when
 Progress::Increment() is called, and also will make sure that a progress
 completed update is reported even if the user doesn't explicitly cause one
-to be sent.") lldb::SBProgress
+to be sent.") lldb::SBProgress;

lldb/include/lldb/API/SBProgress.h

@@ -14,7 +14,19 @@
 
 namespace lldb {
 
-/// A SB API Wrapper around lldb_private::Progress
+/// A Progress indicator helper class.
+///
+/// Any potentially long running sections of code in LLDB should report
+/// progress so that clients are aware of delays that might appear during
+/// debugging. Delays commonly include indexing debug information, parsing
+/// symbol tables for object files, downloading symbols from remote
+/// repositories, and many more things.
+///
+/// The Progress class helps make sure that progress is correctly reported
+/// and will always send an initial progress update, updates when
+/// Progress::Increment() is called, and also will make sure that a progress
+/// completed update is reported even if the user doesn't explicitly cause one
+/// to be sent.
 class LLDB_API SBProgress {
 public:
   /// Construct a progress object with a title, details and a given debugger.
@@ -38,12 +50,12 @@ class LLDB_API SBProgress {
   ///   The debugger for this progress object to report to.
   SBProgress(const char *title, const char *details, uint64_t total_units,
              SBDebugger &debugger);
-  SBProgress(const lldb::SBProgress &rhs);
+
   ~SBProgress();
 
   const SBProgress &operator=(const lldb::SBProgress &rhs);
 
-  void Increment(uint64_t amount = 1, const char *description = nullptr);
+  void Increment(uint64_t amount, const char *description = nullptr);
 
 protected:
   lldb_private::Progress &ref() const;

lldb/source/API/SBProgress.cpp

@@ -1,5 +1,4 @@
-//===-- SBProgress.cpp -------------------------------------------*- C++
-//-*-===//
+//===-- SBProgress.cpp --------------------------------------------------*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -11,23 +10,31 @@
 #include "lldb/Core/Progress.h"
 #include "lldb/Utility/Instrumentation.h"
 
+#include "Utils.h"
+
 using namespace lldb;
 
 SBProgress::SBProgress(const char *title, const char *details,
                        SBDebugger &debugger) {
-  LLDB_INSTRUMENT_VA(this, title, details, debugger)
+  LLDB_INSTRUMENT_VA(this, title, details, debugger);
+
   m_opaque_up = std::make_unique<lldb_private::Progress>(
       title, details, std::nullopt, debugger.get());
 }
 
 SBProgress::SBProgress(const char *title, const char *details,
                        uint64_t total_units, SBDebugger &debugger) {
-  LLDB_INSTRUMENT_VA(this, title, details, total_units, debugger)
+  LLDB_INSTRUMENT_VA(this, title, details, total_units, debugger);
+
   m_opaque_up = std::make_unique<lldb_private::Progress>(
       title, details, total_units, debugger.get());
 }
 
+SBProgress::~SBProgress() = default;
+
 void SBProgress::Increment(uint64_t amount, const char *description) {
+  LLDB_INSTRUMENT_VA(amount, description);
+
   m_opaque_up->Increment(amount, description);
 }